src/v8.gyp - Issue 29747555: Issue 6531 - remove inspector and adapt for Android NDK r16b

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/v8.gyp

Issue 29747555: Issue 6531 - remove inspector and adapt for Android NDK r16b (Closed) Base URL: https://github.com/abby-sergz/v8-googlesource.git@7fece33157c55b16decdf4cde199ca3dddc17db3

Patch Set: address commnet Created April 11, 2018, 9:32 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8.gyp

diff --git a/src/v8.gyp b/src/v8.gyp

index 218b173af2aab365d705728795e7f480463311a9..54559238ec62a97a366d007ba176e895f7b85d17 100644

--- a/src/v8.gyp

+++ b/src/v8.gyp

@@ -37,7 +37,7 @@

'mksnapshot_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',

'v8_os_page_size%': 0,

- 'includes': ['../gypfiles/toolchain.gypi', '../gypfiles/features.gypi', 'inspector/inspector.gypi'],

+ 'includes': ['../gypfiles/toolchain.gypi', '../gypfiles/features.gypi'],

'targets': [

{

'target_name': 'v8',

@@ -526,8 +526,6 @@

'dependencies': [

'v8_libbase',

'v8_libsampler',

- 'inspector/inspector.gyp:protocol_generated_sources#target',

- 'inspector/inspector.gyp:inspector_injected_script#target',

'objs': ['foo.o'],

'variables': {

@@ -539,7 +537,6 @@

'<(SHARED_INTERMEDIATE_DIR)'

'sources': [ ### gcmole(all) ###

- '<@(inspector_all_sources)',

'../include/v8-debug.h',

'../include/v8-platform.h',

'../include/v8-profiler.h',

« no previous file with comments | « src/arm/simulator-arm.cc ('k') | no next file » | no next file with comments »