Issue 6563 - Assure devbuild-number in info module

tests/test_packagerWebExt.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import difflib
 import json
 import os
 import re
 import shutil
 import zipfile
@@ skipping 210 matching lines @@
 
 @pytest.fixture
 def keyfile(tmpdir):
     """Test-privatekey for signing chrome release-package."""
     return os.path.join(os.path.dirname(__file__), 'chrome_rsa.pem')
 
 
 @pytest.fixture
 def lib_files(tmpdir):
     files = packager.Files(['lib'], set())
-    files['ext/a.js'] = 'require("./c.js");\nvar bar;'
+    files['ext/a.js'] = 'require("./c.js");\nrequire("info");\nvar bar;'
     files['lib/b.js'] = 'var foo;'
     files['ext/c.js'] = 'var this_is_c;'
     files['qunit/common.js'] = 'var qunit = {};'
     files['qunit/tests/some_test.js'] = 'var passed = true;'
 
     tmpdir.mkdir('lib').join('b.js').write(files['lib/b.js'])
     ext_dir = tmpdir.mkdir('ext')
     ext_dir.join('a.js').write(files['ext/a.js'])
     ext_dir.join('c.js').write(files['ext/c.js'])
     qunit_dir = tmpdir.mkdir('qunit')
@@ skipping 36 matching lines @@
             generated = comparable_xml(manifest)
             expected = comparable_xml(fp.read())
         else:
             generated = comparable_json(manifest)
             expected = comparable_json(fp.read())
 
     diff = list(difflib.unified_diff(generated, expected, n=0))
     assert len(diff) == 0, '\n'.join(diff)
 
 
-def assert_webpack_bundle(package, prefix, excluded=False):
+def assert_webpack_bundle(package, prefix, is_devbuild, excluded=False):
     libfoo = package.read(os.path.join(prefix, 'lib/foo.js'))
     libfoomap = package.read(os.path.join(prefix, 'lib/foo.js.map'))
 
     assert 'var bar;' in libfoo
+    if is_devbuild:
+        assert 'addonVersion = "1.2.3.1337";' in libfoo
+    else:
+        assert 'addonVersion = "1.2.3";' in libfoo
+
     assert 'webpack:///./ext/a.js' in libfoomap
 
     assert 'var this_is_c;' in libfoo
     assert 'webpack:///./ext/c.js' in libfoomap
 
     assert ('var foo;' in libfoo) != excluded
     assert ('webpack:///./lib/b.js' in libfoomap) != excluded
 
 
 def assert_devenv_scripts(package, prefix, devenv):
@@ skipping 146 matching lines @@
         out_file_path = os.path.abspath(os.path.join(
             os.path.dirname(__file__), os.pardir, out_file))
         assert os.path.exists(out_file_path)
 
     if release and platform == 'chrome':
         assert_chrome_signature(out_file_path, keyfile)
 
     with content_class(out_file_path) as package:
         assert_base_files(package, platform, prefix)
         assert_all_locales_present(package, prefix)
-        assert_webpack_bundle(package, prefix, platform == 'gecko')
+        assert_webpack_bundle(package, prefix, not release and not devenv,
+                              platform == 'gecko')
 
         if platform == 'chrome':
             assert_locale_upfix(package)
 
         assert_devenv_scripts(package, prefix, devenv)
 
         for folder, name, ext in manifests[platform]:
             filename = '{{}}_{}_{}.{{}}'.format(platform, command)
             expected = os.path.join(
                 os.path.dirname(__file__),
                 'expecteddata',
                 filename.format(name, ext),
             )
 
             assert_manifest_content(
                 package.read(os.path.join(folder, '{}.{}'.format(name, ext))),
                 expected,
             )