 Issue 29749588:
  Fixes #53 - Added detection and install links for iOS safari  (Closed) 
  Base URL: https://hg.adblockplus.org/web.adblockplus.org
    
  
    Issue 29749588:
  Fixes #53 - Added detection and install links for iOS safari  (Closed) 
  Base URL: https://hg.adblockplus.org/web.adblockplus.org| Left: | ||
| Right: | 
| OLD | NEW | 
|---|---|
| 1 title=Adblock Plus - Surf the web without annoying ads! | 1 title=Adblock Plus - Surf the web without annoying ads! | 
| 2 noheading=True | 2 noheading=True | 
| 3 localefile=index | 3 localefile=index | 
| 4 | 4 | 
| 5 {# | 5 {# | 
| 6 # This file is part of the Adblock Plus website, | 6 # This file is part of the Adblock Plus website, | 
| 7 # Copyright (C) 2006-present eyeo GmbH | 7 # Copyright (C) 2006-present eyeo GmbH | 
| 8 # | 8 # | 
| 9 # Adblock Plus is free software: you can redistribute it and/or modify | 9 # Adblock Plus is free software: you can redistribute it and/or modify | 
| 10 # it under the terms of the GNU General Public License version 3 as | 10 # it under the terms of the GNU General Public License version 3 as | 
| (...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 187 {{"For transparency, we add all Acceptable Ads to our <a href=\"https://ad blockplus.org/forum/viewforum.php?f=12\">forum</a> so that our community of user s can provide feedback."|translate("footnote-forum")}} | 187 {{"For transparency, we add all Acceptable Ads to our <a href=\"https://ad blockplus.org/forum/viewforum.php?f=12\">forum</a> so that our community of user s can provide feedback."|translate("footnote-forum")}} | 
| 188 </li> | 188 </li> | 
| 189 <li> | 189 <li> | 
| 190 {{"We listen to our users. If an Acceptable Ads proposal is flagged by our community for a legitimate reason, we will remove it from the whitelist."|trans late("footnote-value-users")}} | 190 {{"We listen to our users. If an Acceptable Ads proposal is flagged by our community for a legitimate reason, we will remove it from the whitelist."|trans late("footnote-value-users")}} | 
| 191 </li> | 191 </li> | 
| 192 <li> | 192 <li> | 
| 193 {{"We are able to keep our open source product free by charging large enti ties a fee for whitelisting services. For the other roughly 90 percent of our pa rtners, these services are offered free of charge."|translate("footnote-keep-fre e")}} | 193 {{"We are able to keep our open source product free by charging large enti ties a fee for whitelisting services. For the other roughly 90 percent of our pa rtners, these services are offered free of charge."|translate("footnote-keep-fre e")}} | 
| 194 </li> | 194 </li> | 
| 195 </ul> | 195 </ul> | 
| 196 </div> | 196 </div> | 
| 197 | |
| 198 <script src="/js/vendor/bowser.js"></script> | |
| 199 <script> | |
| 200 if (bowser instanceof Object) | |
| 201 { | |
| 202 var installButton = document.querySelector("install-button"); | |
| 
ire
2018/04/12 07:44:48
Missing class identifier ".install-button"
Also,
 
juliandoucette
2018/04/12 11:58:01
Wow... *blushes*
 | |
| 203 | |
| 204 if (bowser.ios) | |
| 205 { | |
| 206 //because ua-safari is not applied to iOS safari | |
| 207 document.getElementById("content").classList.add("ua-safari"); | |
| 208 installButton.setAttribute("href", "https://itunes.apple.com/us/app/adbloc k-plus-abp-remove-ads-browse-faster-without-tracking/id1028871868?mt=8"); | |
| 
ire
2018/04/12 07:44:48
Why are you handling this here instead of the way
 
juliandoucette
2018/04/12 11:58:01
I ~incorrectly assumed that our backend browser de
 | |
| 209 } | |
| 210 | |
| 211 else if (bowser.samsungBrowser) | |
| 212 { | |
| 213 installButton.setAttribute("href", "https://play.google.com/store/apps/det ails?id=org.adblockplus.adblockplussbrowser"); | |
| 214 } | |
| 215 } | |
| 216 </script> | |
| OLD | NEW |