Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/css/index.css

Issue 29749588: Fixes #53 - Added detection and install links for iOS safari (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Separated samsung browser Created April 12, 2018, 11:54 a.m.
Right Patch Set: Addressed #13 Created April 16, 2018, 3:24 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #content, 1 #content,
2 #blog 2 #blog
3 { 3 {
4 padding-top: 5em; 4 padding-top: 5em;
5 } 5 }
6 6
7 #key-facts h1 7 #key-facts h1
8 { 8 {
9 font-size: 16px; 9 font-size: 16px;
10 } 10 }
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 -o-transition: none; 236 -o-transition: none;
237 transition: none; 237 transition: none;
238 bottom: 4px; 238 bottom: 4px;
239 } 239 }
240 240
241 #content.android .install-button, 241 #content.android .install-button,
242 #content.firefox.ua-firefox .install-button, 242 #content.firefox.ua-firefox .install-button,
243 #content.chrome.ua-chrome .install-button, 243 #content.chrome.ua-chrome .install-button,
244 #content.opera.ua-opera .install-button, 244 #content.opera.ua-opera .install-button,
245 #content.internet-explorer.ua-internet-explorer .install-button, 245 #content.internet-explorer.ua-internet-explorer .install-button,
246 #content.safari .install-button, 246 #content.safari.ua-safari .install-button,
ire 2018/04/12 14:30:32 What's the reason for these changes? (where you re
juliandoucette 2018/04/12 15:02:23 I think that #content.safari applies to #content.s
ire 2018/04/12 15:13:50 But these styles should only be applied if the bot
juliandoucette 2018/04/12 15:30:39 Oops! (I had things backwards.)
247 #content.safari.ua-ios .install-button,
247 #content.yandex-browser.ua-yandex-browser .install-button, 248 #content.yandex-browser.ua-yandex-browser .install-button,
248 #content.edge.ua-edge .install-button, 249 #content.edge.ua-edge .install-button,
249 /* IE6 fixes */ 250 /* IE6 fixes */
250 #content.firefox_ua-firefox .install-button, 251 #content.firefox_ua-firefox .install-button,
251 #content.chrome_ua-chrome .install-button, 252 #content.chrome_ua-chrome .install-button,
252 #content.opera_ua-opera .install-button, 253 #content.opera_ua-opera .install-button,
253 #content.internet-explorer_ua-internet-explorer .install-button, 254 #content.internet-explorer_ua-internet-explorer .install-button,
254 #content.safari_ua-safari .install-button, 255 #content.safari_ua-safari .install-button,
255 #content.yandex-browser_ua-yandex-browser .install-button, 256 #content.yandex-browser_ua-yandex-browser .install-button,
256 #content.edge_ua-edge .install-button 257 #content.edge_ua-edge .install-button
257 { 258 {
258 background: #62c52b; 259 background: #62c52b;
259 background: -webkit-linear-gradient(top, #62c52b, #4f9d22); 260 background: -webkit-linear-gradient(top, #62c52b, #4f9d22);
260 background: -moz-linear-gradient(top, #62c52b, #4f9d22); 261 background: -moz-linear-gradient(top, #62c52b, #4f9d22);
261 background: -ms-linear-gradient(top, #62c52b, #4f9d22); 262 background: -ms-linear-gradient(top, #62c52b, #4f9d22);
262 background: -o-linear-gradient(top, #62c52b, #4f9d22); 263 background: -o-linear-gradient(top, #62c52b, #4f9d22);
263 background: linear-gradient(top, #62c52b, #4f9d22); 264 background: linear-gradient(top, #62c52b, #4f9d22);
264 box-shadow: 0 1px 0 0 #486c15, 0 2px 0 0 #517422; 265 box-shadow: 0 1px 0 0 #486c15, 0 2px 0 0 #517422;
265 text-shadow: 2px 2px 2px #327d14; 266 text-shadow: 2px 2px 2px #327d14;
266 } 267 }
267 268
268 #content.android .install-button:hover, 269 #content.android .install-button:hover,
269 #content.firefox.ua-firefox .install-button:hover, 270 #content.firefox.ua-firefox .install-button:hover,
270 #content.chrome.ua-chrome .install-button:hover, 271 #content.chrome.ua-chrome .install-button:hover,
271 #content.opera.ua-opera .install-button:hover, 272 #content.opera.ua-opera .install-button:hover,
272 #content.internet-explorer.ua-internet-explorer .install-button:hover, 273 #content.internet-explorer.ua-internet-explorer .install-button:hover,
273 #content.safari .install-button:hover, 274 #content.safari.ua-safari .install-button:hover,
275 #content.safari.ua-ios .install-button:hover,
274 #content.yandex-browser.ua-yandex-browser .install-button:hover, 276 #content.yandex-browser.ua-yandex-browser .install-button:hover,
275 #content.edge.ua-edge .install-button:hover, 277 #content.edge.ua-edge .install-button:hover,
276 /* IE6 fixes */ 278 /* IE6 fixes */
277 #content.firefox_ua-firefox .install-button:hover, 279 #content.firefox_ua-firefox .install-button:hover,
278 #content.chrome_ua-chrome .install-button:hover, 280 #content.chrome_ua-chrome .install-button:hover,
279 #content.opera_ua-opera .install-button:hover, 281 #content.opera_ua-opera .install-button:hover,
280 #content.internet-explorer_ua-internet-explorer .install-button:hover, 282 #content.internet-explorer_ua-internet-explorer .install-button:hover,
281 #content.safari_ua-safari .install-button:hover, 283 #content.safari_ua-safari .install-button:hover,
282 #content.yandex-browser_ua-yandex-browser .install-button:hover, 284 #content.yandex-browser_ua-yandex-browser .install-button:hover,
283 #content.edge_ua-edge .install-button:hover 285 #content.edge_ua-edge .install-button:hover
284 { 286 {
285 box-shadow: 0px 2px 7px #486c15, 0 1px 0 0 #486c15; 287 box-shadow: 0px 2px 7px #486c15, 0 1px 0 0 #486c15;
286 } 288 }
287 289
288 #content.android .install-button:active, 290 #content.android .install-button:active,
289 #content.firefox.ua-firefox .install-button:active, 291 #content.firefox.ua-firefox .install-button:active,
290 #content.chrome.ua-chrome .install-button:active, 292 #content.chrome.ua-chrome .install-button:active,
291 #content.opera.ua-opera .install-button:active, 293 #content.opera.ua-opera .install-button:active,
292 #content.internet-explorer.ua-internet-explorer .install-button:active, 294 #content.internet-explorer.ua-internet-explorer .install-button:active,
293 #content.safari .install-button:active, 295 #content.safari.ua-safari .install-button:active,
296 #content.safari.ua-ios .install-button:active,
294 #content.yandex-browser.ua-yandex-browser .install-button:active, 297 #content.yandex-browser.ua-yandex-browser .install-button:active,
295 #content.edge.ua-edge .install-button:active, 298 #content.edge.ua-edge .install-button:active,
296 /* IE6 fixes */ 299 /* IE6 fixes */
297 #content.firefox_ua-firefox .install-button:active, 300 #content.firefox_ua-firefox .install-button:active,
298 #content.chrome_ua-chrome .install-button:active, 301 #content.chrome_ua-chrome .install-button:active,
299 #content.opera_ua-opera .install-button:active, 302 #content.opera_ua-opera .install-button:active,
300 #content.internet-explorer_ua-internet-explorer .install-button:active, 303 #content.internet-explorer_ua-internet-explorer .install-button:active,
301 #content.safari_ua-safari .install-button:active, 304 #content.safari_ua-safari .install-button:active,
302 #content.yandex-browser_ua-yandex-browser .install-button:active, 305 #content.yandex-browser_ua-yandex-browser .install-button:active,
303 #content.edge_ua-edge .install-button:active 306 #content.edge_ua-edge .install-button:active
304 { 307 {
305 background: #4f9d22; 308 background: #4f9d22;
306 background: -webkit-linear-gradient(bottom, #62c52b, #4f9d22); 309 background: -webkit-linear-gradient(bottom, #62c52b, #4f9d22);
307 background: -moz-linear-gradient(bottom, #62c52b, #4f9d22); 310 background: -moz-linear-gradient(bottom, #62c52b, #4f9d22);
308 background: -ms-linear-gradient(bottom, #62c52b, #4f9d22); 311 background: -ms-linear-gradient(bottom, #62c52b, #4f9d22);
309 background: -o-linear-gradient(bottom, #62c52b, #4f9d22); 312 background: -o-linear-gradient(bottom, #62c52b, #4f9d22);
310 background: linear-gradient(bottom, #62c52b, #4f9d22); 313 background: linear-gradient(bottom, #62c52b, #4f9d22);
311 box-shadow: 0px 0px 7px #486c15; 314 box-shadow: 0px 0px 7px #486c15;
312 } 315 }
313 316
314 #content.firefox #install-firefox, #content.chrome #install-chrome, 317 #content.firefox #install-firefox, #content.chrome #install-chrome,
315 #content.opera #install-opera, #content.android #install-android, 318 #content.opera #install-opera, #content.android #install-android,
316 #content.internet-explorer #install-internet-explorer, 319 #content.internet-explorer #install-internet-explorer,
317 #content.ua-safari #install-safari, 320 #content.safari.ua-ios #install-ios-safari,
318 #content.ua-ios #install-ios,
319 #content.yandex-browser #install-yandex-browser, 321 #content.yandex-browser #install-yandex-browser,
320 #content.edge #install-edge 322 #content.edge #install-edge
321 { 323 {
322 display: inline-block; 324 display: inline-block;
323 } 325 }
326
327 #content.safari:not(.ua-ios) #install-safari { display: inline-block; }
ire 2018/04/16 15:42:21 NIT: You didn't need to make this its own rule, yo
324 328
325 #other-platform ul 329 #other-platform ul
326 { 330 {
327 list-style: none; 331 list-style: none;
328 display: inline-block; 332 display: inline-block;
329 margin: 0px; 333 margin: 0px;
330 padding: 0; 334 padding: 0;
331 vertical-align: bottom; 335 vertical-align: bottom;
332 } 336 }
333 337
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 line-height: 1.4; 621 line-height: 1.4;
618 color: #000; 622 color: #000;
619 background-color: #fff; 623 background-color: #fff;
620 border: 2px solid #a1a1a1; 624 border: 2px solid #a1a1a1;
621 } 625 }
622 626
623 #ready-for-windows-notice 627 #ready-for-windows-notice
624 { 628 {
625 margin-bottom: 30px; 629 margin-bottom: 30px;
626 } 630 }
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld