Issue 6565 - Ensure the URL is known for requests we might block

lib/requestBlocker.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 133 matching lines @@
   // path (unlike "originUrl" on Firefox), but is still good enough
   // (in case the tab/frame is unknown) for the $domain filter option
   // and most document exception rules which only match the domain part.
   else if (details.initiator)
     originUrl = new URL(details.initiator);
 
   let page = null;
   let frame = null;
   if (details.tabId != -1)
   {
-    page = new ext.Page({id: details.tabId});
+    page = new ext.Page({id: details.tabId, url: details.url});

[Sebastian Noack, 2018/04/12 13:27:09]

Shouldn't this be rather the originUrl than the url of this request? But then
again I don't get where the error is comming from, since we fall back to the
originURL anyway, and the code path that touches the page object in
checkWhitelisted() isn't even hit as long as an originUrl is given.

[Sebastian Noack, 2018/04/12 13:38:09]

However, if no originUrl is given these request should be ignored now, by
https://issues.adblockplus.org/ticket/6544. Can you still reproduce the error?

[kzar, 2018/04/13 15:36:37]

Yea, unfortunately I can.

[kzar, 2018/04/13 15:36:37]

Yea, good point. Well since we now know why you couldn't reproduce this to
initially (disabled new tab page) perhaps you could try again to figure out
what's happening? I'd rather not change something that I don't fully understand
in case I'm missing something important.

[Sebastian Noack, 2018/04/14 03:21:26]

How do I get that new tab page?

     frame = ext.getFrame(
       details.tabId,
       // We are looking for the frame that contains the element which
       // has triggered this request. For most requests (e.g. images) we
       // can just use the request's frame ID, but for subdocument requests
       // (e.g. iframes) we must instead use the request's parent frame ID.
       details.type == "sub_frame" ? details.parentFrameId : details.frameId
     );
   }
 
@@ skipping 100 matching lines @@
 
 port.on("request.blockedByRTCWrapper", (msg, sender) =>
 {
   return ext.webRequest.onBeforeRequest._dispatch(
      new URL(msg.url),
      "webrtc",
      sender.page,
      sender.frame
   ).includes(false);
 });