Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29750621: #10073 - Fix provisioning of downloadserver role (Closed)

Created:
April 12, 2018, 9:10 p.m. by f.lopez
Modified:
April 16, 2018, 2:38 p.m.
Reviewers:
mathias
CC:
Fred
Visibility:
Public.

Description

#10073 - Fix provisioning of downloadserver role

Patch Set 1 #

Total comments: 6

Patch Set 2 : For comments 2 and 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M modules/downloadserver/manifests/init.pp View 1 3 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 5
f.lopez
April 12, 2018, 9:10 p.m. (2018-04-12 21:10:13 UTC) #1
mathias
https://codereview.adblockplus.org/29750621/diff/29750622/modules/downloadserver/manifests/init.pp File modules/downloadserver/manifests/init.pp (right): https://codereview.adblockplus.org/29750621/diff/29750622/modules/downloadserver/manifests/init.pp#newcode58 modules/downloadserver/manifests/init.pp:58: onlyif => "test ! -d /var/www/downloads/.hg" This should be ...
April 13, 2018, 4:30 a.m. (2018-04-13 04:30:54 UTC) #2
f.lopez
https://codereview.adblockplus.org/29750621/diff/29750622/modules/downloadserver/manifests/init.pp File modules/downloadserver/manifests/init.pp (right): https://codereview.adblockplus.org/29750621/diff/29750622/modules/downloadserver/manifests/init.pp#newcode58 modules/downloadserver/manifests/init.pp:58: onlyif => "test ! -d /var/www/downloads/.hg" On 2018/04/13 04:30:54, ...
April 13, 2018, 9:13 p.m. (2018-04-13 21:13:20 UTC) #3
f.lopez
April 13, 2018, 9:14 p.m. (2018-04-13 21:14:22 UTC) #4
mathias
April 13, 2018, 10:48 p.m. (2018-04-13 22:48:51 UTC) #5
LGTM.

As discussed, please split this up into two commits:

- #10073 - Explicitly ensure downloads directory in downloadserver role
- #10073 - Explicitly ensure rsync package in downloadserver role

Powered by Google App Engine
This is Rietveld