Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29752571: Noissue - Removed background.js (Closed)

Created:
April 14, 2018, 12:27 p.m. by Sebastian Noack
Modified:
April 16, 2018, 11:49 a.m.
Reviewers:
kzar
Visibility:
Public.

Description

Noissue - Removed background.js

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -38 lines) Patch
R background.js View 1 chunk +0 lines, -37 lines 0 comments Download
M lib/filterComposer.js View 1 chunk +16 lines, -0 lines 1 comment () Download
M metadata.chrome View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6
Sebastian Noack
For reference, the background.js script is historical. It used to include all code before we ...
April 14, 2018, 12:30 p.m. (2018-04-14 12:30:44 UTC) #1
kzar
> While the "forward" message (the last remaining code in > background.js) could be used ...
April 16, 2018, 11:08 a.m. (2018-04-16 11:08:22 UTC) #2
Sebastian Noack
On 2018/04/16 11:08:22, kzar wrote: > > While the "forward" message (the last remaining code ...
April 16, 2018, 11:17 a.m. (2018-04-16 11:17:10 UTC) #3
kzar
On 2018/04/16 11:17:10, Sebastian Noack wrote: > As mentioned on IRC, I accidentally already pushed ...
April 16, 2018, 11:20 a.m. (2018-04-16 11:20:33 UTC) #4
Sebastian Noack
On 2018/04/16 11:20:33, kzar wrote: > Well yea, the commit that already got pushed isn't ...
April 16, 2018, 11:24 a.m. (2018-04-16 11:24:34 UTC) #5
kzar
April 16, 2018, 11:46 a.m. (2018-04-16 11:46:30 UTC) #6
Along with your follow up changes this LGTM

Powered by Google App Engine
This is Rietveld