Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29753560: Noissue - Make branch 'safari' compatible with #6021 (Closed)

Created:
April 16, 2018, 10:14 a.m. by tlucas
Modified:
April 16, 2018, 3:01 p.m.
Reviewers:
Sebastian Noack
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/file/75dc7e753910
Visibility:
Public.

Description

Noissue - Make branch 'safari' compatible with #6021 See comments in https://codereview.adblockplus.org/29751598/diff/29751599/sitescripts/extensions/bin/createNightlies.py for more context. This patch should be pushed to the bookmark 'safari'

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M build.py View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 2
tlucas
Patch Set 1 * Let build.py in 'safari' be forward compatible with #6021
April 16, 2018, 10:17 a.m. (2018-04-16 10:17:21 UTC) #1
Sebastian Noack
April 16, 2018, 10:22 a.m. (2018-04-16 10:22:05 UTC) #2
LGTM. (FWIW, one review would have been sufficient.)

Powered by Google App Engine
This is Rietveld