Noissue - Renamed "forward" message to "composer.forward"

composer.postload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 388 matching lines @@
     {
       // Only the top frame keeps a record of the popup window's ID,
       // so if this isn't the top frame we need to pass the ID on.
       if (window == window.top)
       {
         blockelementPopupId = popupId;
       }
       else
       {
         browser.runtime.sendMessage({
-          type: "forward",
+          type: "composer.forward",
           payload: {type: "composer.content.dialogOpened", popupId}
         });
       }
     });
 
     if (selectors.length > 0)
       highlightElements(selectors.join(","));
 
     highlightElement(currentElement, "#fd1708", "#f6a1b5");
   });
@@ skipping 22 matching lines @@
 
 // We're done with the block element feature for now, tidy everything up.
 function deactivateBlockElement(popupAlreadyClosed)
 {
   if (currentlyPickingElement)
     stopPickingElement();
 
   if (blockelementPopupId != null && !popupAlreadyClosed)
   {
     browser.runtime.sendMessage({
-      type: "forward",
+      type: "composer.forward",
       targetPageId: blockelementPopupId,
       payload:
       {
         type: "composer.dialog.close"
       }
     });
   }
 
   blockelementPopupId = null;
   lastRightClickEvent = null;
@@ skipping 23 matching lines @@
   // element.
   //   We also need to make sure that the previous right click event,
   // if there is one, is removed. We don't know which frame it is in so we must
   // send a message to the other frames to clear their old right click events.
   document.addEventListener("contextmenu", event =>
   {
     lastRightClickEvent = event;
     lastRightClickEventIsMostRecent = true;
 
     browser.runtime.sendMessage({
-      type: "forward",
+      type: "composer.forward",
       payload:
       {
         type: "composer.content.clearPreviousRightClickEvent"
       }
     });
   }, true);
 
   ext.onMessage.addListener((message, sender, sendResponse) =>
   {
     switch (message.type)
@@ skipping 48 matching lines @@
       case "composer.content.dialogOpened":
         if (window == window.top)
           blockelementPopupId = message.popupId;
         break;
       case "composer.content.dialogClosed":
         // The onRemoved hook for the popup can create a race condition, so we
         // to be careful here. (This is not perfect, but best we can do.)
         if (window == window.top && blockelementPopupId == message.popupId)
         {
           browser.runtime.sendMessage({
-            type: "forward",
+            type: "composer.forward",
             payload:
             {
               type: "composer.content.finished",
               popupAlreadyClosed: true
             }
           });
         }
         break;
     }
   });
 
   if (window == window.top)
     browser.runtime.sendMessage({type: "composer.ready"});
 
   return true;
 }
 
 if (document instanceof HTMLDocument)
 {
   // There's a bug in Firefox that causes document_end content scripts to run
   // before document_start content scripts on extension startup. In this case
   // the ext object is undefined, we fail to initialize, and initializeComposer
   // returns false. As a workaround, try again after a timeout.
   // https://bugzilla.mozilla.org/show_bug.cgi?id=1395287
   if (!initializeComposer())
     setTimeout(initializeComposer, 2000);
 }