Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 29753571: Issue 6582 - Wrap tabs.remove (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by Manish Jethani
Modified:
3 months ago
Reviewers:
kzar, Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 6582 - Wrap tabs.remove

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M polyfill.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
Manish Jethani
3 months ago (2018-04-16 12:45:01 UTC) #1
Manish Jethani
Patch Set 1
3 months ago (2018-04-16 12:46:04 UTC) #2
Sebastian Noack
It seems, we don't need to be able to handle the asynchronous result of tabs.remove(). ...
3 months ago (2018-04-16 15:26:18 UTC) #3
kzar
On 2018/04/16 15:26:18, Sebastian Noack wrote: > ... I wonder what our policy regarding the ...
3 months ago (2018-04-16 17:12:30 UTC) #4
Manish Jethani
On 2018/04/16 17:12:30, kzar wrote: > On 2018/04/16 15:26:18, Sebastian Noack wrote: > > ...
3 months ago (2018-04-16 21:40:31 UTC) #5
Sebastian Noack
3 months ago (2018-04-17 04:35:37 UTC) #6
Fair enough. LGTM then.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5