Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29753574: Issue 6565 - Ignore requests sent by Chrome's new tab page (Closed)

Created:
April 16, 2018, 1:02 p.m. by Sebastian Noack
Modified:
April 19, 2018, 4:22 p.m.
Reviewers:
kzar
Visibility:
Public.

Description

Issue 6565 - Ignore requests sent by Chrome's new tab page

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Separate checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M lib/requestBlocker.js View 1 1 chunk +19 lines, -25 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
This change essentially ignores any requests that we neither know the frame for nor have ...
April 16, 2018, 1:07 p.m. (2018-04-16 13:07:59 UTC) #1
kzar
On 2018/04/16 13:07:59, Sebastian Noack wrote: > This change essentially ignores any requests that we ...
April 16, 2018, 3:53 p.m. (2018-04-16 15:53:38 UTC) #2
Sebastian Noack
On 2018/04/16 15:53:38, kzar wrote: > I wonder if we should update the page/frame structure ...
April 16, 2018, 4:42 p.m. (2018-04-16 16:42:21 UTC) #3
kzar
April 17, 2018, 10:18 a.m. (2018-04-17 10:18:51 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld