Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(558)

Issue 29754555: Noissue - Use selectattr() filter to filter page metadata

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by Sebastian Noack
Modified:
2 months, 1 week ago
Visibility:
Public.

Description

Noissue - Use selectattr() filter to filter page metadata

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M includes/product-topics-accordion.tmpl View 1 chunk +3 lines, -1 line 0 comments Download
M templates/product-home.tmpl View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18
Sebastian Noack
This is a proof of concept, how help.eyeo.com could look like if we remove filtering ...
5 months ago (2018-04-17 06:23:27 UTC) #1
juliandoucette
CC Ire (She has implemented most of the help centre.) This is too verbose for ...
5 months ago (2018-04-17 10:43:07 UTC) #2
Sebastian Noack
On 2018/04/17 10:43:07, juliandoucette wrote: > CC Ire (She has implemented most of the help ...
5 months ago (2018-04-17 12:18:13 UTC) #3
Vasily Kuznetsov
On 2018/04/17 12:18:13, Sebastian Noack wrote: > On 2018/04/17 10:43:07, juliandoucette wrote: > > CC ...
5 months ago (2018-04-17 15:12:53 UTC) #4
Sebastian Noack
On 2018/04/17 15:12:53, Vasily Kuznetsov wrote: > The current implementation of `get_pages_metadata` is a fairly ...
5 months ago (2018-04-17 16:20:09 UTC) #5
Jon Sonesen
On 2018/04/17 16:20:09, Sebastian Noack wrote: > On 2018/04/17 15:12:53, Vasily Kuznetsov wrote: > > ...
5 months ago (2018-04-17 18:01:41 UTC) #6
Vasily Kuznetsov
On 2018/04/17 16:20:09, Sebastian Noack wrote: > On 2018/04/17 15:12:53, Vasily Kuznetsov wrote: > > ...
5 months ago (2018-04-17 18:12:10 UTC) #7
juliandoucette
CC Manvel This is becoming a lot to read :D. I'd like to get feedback ...
5 months ago (2018-04-18 11:24:39 UTC) #8
saroyanm
On 2018/04/18 11:24:39, juliandoucette wrote: > CC Manvel > > This is becoming a lot ...
5 months ago (2018-04-18 14:40:24 UTC) #9
ire
Hey everyone, sorry for the late response I was away the last 2 days. Here ...
5 months ago (2018-04-19 09:48:15 UTC) #10
Sebastian Noack
On 2018/04/19 09:48:15, ire wrote: > An ideal solution would be what Vasily suggested, for ...
5 months ago (2018-04-19 10:23:11 UTC) #11
ire
On 2018/04/19 10:23:11, Sebastian Noack wrote: > On 2018/04/19 09:48:15, ire wrote: > > An ...
5 months ago (2018-04-19 10:58:46 UTC) #12
Sebastian Noack
On 2018/04/19 10:58:46, ire wrote: > Thanks Sebastian! I would be fine with a solution ...
5 months ago (2018-04-19 11:06:26 UTC) #13
Vasily Kuznetsov
On 2018/04/19 11:06:26, Sebastian Noack wrote: > On 2018/04/19 10:58:46, ire wrote: > > Thanks ...
5 months ago (2018-04-19 15:23:23 UTC) #14
juliandoucette
On 2018/04/19 10:23:11, Sebastian Noack wrote: > On 2018/04/19 09:48:15, ire wrote: > > An ...
4 months, 4 weeks ago (2018-04-23 14:15:26 UTC) #15
juliandoucette
On 2018/04/23 14:15:26, juliandoucette wrote: > Can you enable us to use a filter instead ...
3 months, 1 week ago (2018-06-08 17:12:21 UTC) #16
Vasily Kuznetsov
On 2018/06/08 17:12:21, juliandoucette wrote: > On 2018/04/23 14:15:26, juliandoucette wrote: > > Can you ...
2 months, 1 week ago (2018-07-09 18:07:45 UTC) #17
Jon Sonesen
2 months, 1 week ago (2018-07-09 18:28:00 UTC) #18
On 2018/07/09 18:07:45, Vasily Kuznetsov wrote:
> On 2018/06/08 17:12:21, juliandoucette wrote:
> > On 2018/04/23 14:15:26, juliandoucette wrote:
> > > Can you enable us to use a filter instead of a macro?
> > > 
> > > e.g.
> > > 
> > > {% for page in pages | query(category="Example") %}
> > 
> > BUMP
> 
> Hi Julian.
> 
> I'm a bit unsure what we want to do here: upgrade Jinja and use selectattr()
or
> create a new, less verbose, filter in CMS or create same filter in
> website-defaults. Perhaps we should create a ticket for the desired change and
> then move things forward there.
> 
> Cheers,
> Vasily
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5