Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29754559: Issue 54 - Add documentation for the $csp filter option (Closed)

Created:
April 17, 2018, 1:50 p.m. by kzar
Modified:
May 16, 2018, 12:14 p.m.
Visibility:
Public.

Description

Issue 54 - Add documentation for the $csp filter option

Patch Set 1 #

Patch Set 2 : Capitalise Opera #

Patch Set 3 : Incorporate Sebastian's suggestions #

Patch Set 4 : Add parenthesis for version requirement #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pages/filters.html View 1 2 3 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 6
kzar
Patch Set 1
April 17, 2018, 1:51 p.m. (2018-04-17 13:51:41 UTC) #1
kzar
Patch Set 2: Capitalise Opera
April 17, 2018, 2 p.m. (2018-04-17 14:00:33 UTC) #2
kzar
Patch Set 3 : Incorporate Sebastian's suggestions
April 17, 2018, 3:11 p.m. (2018-04-17 15:11:24 UTC) #3
kzar
Patch Set 4 : Add parenthesis for version requirement
April 17, 2018, 3:45 p.m. (2018-04-17 15:45:58 UTC) #4
Sebastian Noack
LGTM
April 17, 2018, 4:04 p.m. (2018-04-17 16:04:39 UTC) #5
juliandoucette
April 23, 2018, 2:08 p.m. (2018-04-23 14:08:19 UTC) #6
LGTM

https://codereview.adblockplus.org/29754559/diff/29754569/pages/filters.html
File pages/filters.html (right):

https://codereview.adblockplus.org/29754559/diff/29754569/pages/filters.html#...
pages/filters.html:174: {{csp Content Security Policies: The option
<code><fix>csp=script-src: 'none'</fix></code> causes a Content Security Policy
header of <code><fix>script-src: 'none'</fix></code> to be injected into HTTP
responses for requested documents matching the filter — assuming that exception
rules with the same option don't also match and that the document isn’t
whitelisted. The Content Security Policy <code><fix>script-src:
'none'</fix></code> would in turn block all scripts — including inline — for the
document. This filter option should generally be avoided, except as a last
resort to counter advanced circumvention. (Adblock Plus 3.1 or higher
required.)}}
Detail: A description list would be more appropriate here (but it would not be
appropriate to change this list format in this change).

Powered by Google App Engine
This is Rietveld