Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: pages/exceptions/popup.tmpl

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)
Patch Set: Addressed Dave's feedback Created June 4, 2018, 1:21 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 title = $popup Exception - ABP Test Pages 1 title = $popup Exception
2 template = testcase 2 template = testcase
3 3
4 {% set testcase_moreinfo = [ 4 {% set testcase_moreinfo = [
5 ("Filter Options", "https://adblockplus.org/filters#options"), 5 ("Filter Options", "https://adblockplus.org/filters#options"),
6 ] %} 6 ] %}
7 7
8 <script> 8 <script>
9 function do_popup() 9 function do_popup()
10 { 10 {
11 window.open("/en/exceptions/popup") 11 window.open("/en/exceptions/popup")
12 } 12 }
13 </script> 13 </script>
14 14
15 <section class="site-panel"> 15 <section class="site-panel">
16 <h2>$popup Exception</h2> 16 <h2>$popup Exception</h2>
17 <p>Check that usage of the $popup filter option in an exception filter works a s expected.</p> 17 <p>Check that usage of the $popup filter option in an exception filter works a s expected.</p>
18 <p>With the filter(s) displayed below each test case added to ABP (or with the testcase subscription installed and active), the popup should not be blocked an d open succesfully.</p>
18 </section> 19 </section>
19 20
20 <section class="site-panel"> 21 <section class="site-panel">
21 <h2>Link-based popup</h2> 22 <h2>Link-based popup</h2>
22 <div class="testcase-container"> 23 <div class="testcase-container">
23 <a href="/en/exceptions/popup" target="_blank">Link popup</a><br><br> 24 <a href="/en/exceptions/popup" target="_blank">Link popup</a><br><br>
24 </div> 25 </div>
25 <h3>Filters</h3> 26 <h3>Filters</h3>
26 ||testpages.adblockplus.org/en/exceptions/popup^$popup<br> 27 <pre>||testpages.adblockplus.org/en/exceptions/popup^$popup</pre>
27 @@||testpages.adblockplus.org/en/exceptions/popup^$popup 28 <pre>@@||testpages.adblockplus.org/en/exceptions/popup^$popup</pre>
28 </section> 29 </section>
29 30
30 <section class="site-panel"> 31 <section class="site-panel">
31 <h2>Script-based popup</h2> 32 <h2>Script-based popup</h2>
32 <div class="testcase-container"> 33 <div class="testcase-container">
33 <button onclick="do_popup();">window.open() popup</button> 34 <button onclick="do_popup();">window.open() popup</button>
34 </div> 35 </div>
35 <h3>Filters</h3> 36 <h3>Filters</h3>
36 ||testpages.adblockplus.org/en/popuptarget^$popup 37 ||testpages.adblockplus.org/en/popuptarget^$popup
37 @@||testpages.adblockplus.org/en/filters/popup-exception^$popup 38 @@||testpages.adblockplus.org/en/filters/popup-exception^$popup
38 </section> 39 </section>
OLDNEW

Powered by Google App Engine
This is Rietveld