Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: templates/testcase.tmpl

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)
Left Patch Set: Created April 18, 2018, 11:54 a.m.
Right Patch Set: Fixed README title Created June 7, 2018, 1:58 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « templates/default.tmpl ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <title>{{ title }}</title> 4 <title>{{ title }} - ABP Test Pages</title>
5 » <link rel="stylesheet" href="/css/testpages.css"> 5 <link rel="stylesheet" href="/css/testpages.css">
6 » <meta name="viewport" content="width=device-width, initial-scale=1"> 6 <link rel="icon" type="image/png" sizes="32x32" href="/images/abp-32.png">
kzar 2018/04/19 13:08:25 Nit: Git warned me that you've accidentally put a
7 <meta name="viewport" content="width=device-width, initial-scale=1">
7 </head> 8 </head>
8 <body> 9 <body>
9 <? include header ?> 10 <? include header ?>
10 <div class="site-container"> 11 <div class="site-container">
11 12
kzar 2018/04/19 13:08:26 Nit: Please could you remove the trailing whitespa
12 <section class="site-panel site-breadcrumbs"> 13 <section class="site-panel site-breadcrumbs">
13 » <a href="/" target="_top">Home</a> 14 <a href="/" target="_top">Home</a>
kzar 2018/04/19 13:08:23 Nit: Git warned me that you've accidentally put a
14 » > <a href="testcases" target="_top">Test cases</a> 15 > <a href="testcases" target="_top">Test cases</a>
kzar 2018/04/19 13:08:26 Nit: Git warned me that you've accidentally put a
15 {{ breadcrumb|safe }} 16 {{ breadcrumb|safe }}
16 » </section> 17 </section>
kzar 2018/04/19 13:08:25 Nit: Git warned me that you've accidentally put a
17 18
18 {{ body|safe }} 19 {{ body|safe }}
19 20
20 {% if testcase_howtotest_steps or testcase_howtotest_notes %} 21 {% if testcase_howtotest_steps or testcase_howtotest_notes %}
21 <section class="site-panel"> 22 <section class="site-panel">
22 <h2>How to test</h2> 23 <h2>How to test</h2>
23 {% if testcase_howtotest_steps %} 24 {% if testcase_howtotest_steps %}
24 <h3>Steps</h3> 25 <h3>Steps</h3>
25 <ul> 26 <ul>
26 {% for step in testcase_howtotest_steps %} 27 {% for step in testcase_howtotest_steps %}
27 <li>{{ step }}</li> 28 <li>{{ step }}</li>
28 {% endfor %} 29 {% endfor %}
29 </ul> 30 </ul>
30 {% endif %} 31 {% endif %}
31 {% if testcase_howtotest_notes %} 32 {% if testcase_howtotest_notes %}
32 <h3>Notes</h3> 33 <h3>Notes</h3>
33 <ul> 34 <ul>
34 {% for note in testcase_howtotest_notes %} 35 {% for note in testcase_howtotest_notes %}
35 <li>{{ note }}</li> 36 <li>{{ note }}</li>
36 {% endfor %} 37 {% endfor %}
37 </ul> 38 </ul>
38 {% endif %} 39 {% endif %}
39 » </section> 40 </section>
kzar 2018/04/19 13:08:23 Nit: Git warned me that you've accidentally put a
40 » {% endif %} 41 {% endif %}
kzar 2018/04/19 13:08:26 Nit: Git warned me that you've accidentally put a
41
42 42
43 {% if testcase_filters %} 43 {% if testcase_filters %}
44 » <section class="site-panel"> 44 <section class="site-panel">
kzar 2018/04/19 13:08:24 Nit: Git warned me that you've accidentally put a
45 <h2>Example filters</h2> 45 <h2>Example filters</h2>
46 <p>Example filters that can be used when testing this page.</p> 46 <p>Example filters that can be used when testing this page.</p>
47 {% for filter in testcase_filters %} 47 {% for filter in testcase_filters %}
48 <div class="testcase-filter"> 48 <div class="testcase-filter">
49 <p class="filter">{{filter[0]}}</p> 49 <p class="filter">{{filter[0]}}</p>
50 <p class="description">{{filter[1]}}</p> 50 <p class="description">{{filter[1]}}</p>
51 </div> 51 </div>
52 {%endfor %} 52 {% endfor %}
53 » </section> 53 </section>
kzar 2018/04/19 13:08:27 Nit: Git warned me that you've accidentally put a
54 » {% endif %} 54 {% endif %}
kzar 2018/04/19 13:08:24 Nit: Git warned me that you've accidentally put a
55 55
56 » {% if testcase_passnotes %} 56 {% if testcase_passnotes %}
kzar 2018/04/19 13:08:28 Nit: Git warned me that you've accidentally put a
57 <section class="site-panel"> 57 <section class="site-panel">
58 <h2>Pass</h2> 58 <h2>Pass</h2>
59 {% for note in testcase_passnotes %} 59 {% for note in testcase_passnotes %}
60 <p>{{ note }}</p> 60 <p>{{ note }}</p>
61 {% endfor %} 61 {% endfor %}
62 » </section> 62 </section>
kzar 2018/04/19 13:08:24 Nit: Git warned me that you've accidentally put a
63 » {% endif %} 63 {% endif %}
kzar 2018/04/19 13:08:27 Nit: Git warned me that you've accidentally put a
64 64
65 » {% if testcase_moreinfo %} 65 {% if testcase_moreinfo %}
kzar 2018/04/19 13:08:25 Nit: Git warned me that you've accidentally put a
66 » <section class="site-panel"> 66 <section class="site-panel">
kzar 2018/04/19 13:08:26 Nit: Git warned me that you've accidentally put a
67 <h2>More information</h2> 67 <h2>More information</h2>
68 <ul> 68 <ul>
69 {% for link in testcase_moreinfo %} 69 {% for link in testcase_moreinfo %}
70 <li><a href="{{link[1]}}">{{link[0]}}</a></li> 70 <li><a href="{{link[1]}}">{{link[0]}}</a></li>
71 {%endfor %} 71 {% endfor %}
72 </ul> 72 </ul>
73 » </section> 73 </section>
kzar 2018/04/19 13:08:28 Nit: Git warned me that you've accidentally put a
74 » {% endif %} 74 {% endif %}
kzar 2018/04/19 13:08:26 Nit: Git warned me that you've accidentally put a
75
76
77 »
78
79 75
80 </div> 76 </div>
81 77
kzar 2018/04/19 13:08:25 Nit: Please could you remove these extra blank lin
82 » 78 <? include footer ?>
83 79
84 » 80 <script>
85 81 function pagelog(message, ) {
86 » <? include footer ?> 82 var log = document.getElementById("testcase-output");
87 83 log.innerText = log.innerText + message + "\n";
84 console.log(message);
85 }
86 </script>
88 </body> 87 </body>
89 </html> 88 </html>
LEFTRIGHT
« templates/default.tmpl ('k') | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld