pages/circumvention/anoniframe-documentwrite.tmpl - Issue 29755578: Issue 2148 - Rewrite the testpages test suite

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: pages/circumvention/anoniframe-documentwrite.tmpl

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)

Left Patch Set: Addressed Dave's feedback Created June 4, 2018, 1:21 p.m.

Right Patch Set: Fixed README title Created June 7, 2018, 1:58 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 title = Anonymous Frame document.write() - Circumvention	1 title = Anonymous Frame document.write() - Circumvention
kzar 2018/06/04 17:17:29 Nit: Please can you delete the trailing space? Nit: Please can you delete the trailing space? rossg 2018/06/07 10:30:24 Done. Show quoted text On 2018/06/04 17:17:29, kzar wrote: > Nit: Please can you delete the trailing space? Done.
2 template = testcase	2 template = testcase

3	3

4 <script>	4 <script>

5 setTimeout(function()	5 setTimeout(function()

6 {	6 {

7 var iframe = document.getElementById("append");	7 var iframe = document.getElementById("append");

8 var span = document.createElement("span");	8 var span = document.createElement("span");

9 span.className = "testcase-circ-anoniframe-docwrite";	9 span.className = "testcase-circ-anoniframe-docwrite";

10 span.textContent = "This text should be hidden";	10 span.textContent = "This text should be hidden";

11 iframe.contentDocument.body.appendChild(span);	11 iframe.contentDocument.body.appendChild(span);

(...skipping 16 matching lines...) Expand all Loading...
28 Subframe (Element.appendChild): [<iframe id="append"></iframe>]	28 Subframe (Element.appendChild): [<iframe id="append"></iframe>]

29 </p>	29 </p>

30	30

31 <p>	31 <p>

32 Subframe (document.write): [<iframe id="write"></iframe>]	32 Subframe (document.write): [<iframe id="write"></iframe>]

33 </p>	33 </p>

34 </div>	34 </div>

35 <h3>Related links</h3>	35 <h3>Related links</h3>

36 <p><a href="https://issues.adblockplus.org/ticket/3185">Issue #3185</a></p>	36 <p><a href="https://issues.adblockplus.org/ticket/3185">Issue #3185</a></p>

37 </section>	37 </section>

LEFT	RIGHT