Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: pages/exceptions/xmlhttprequest.tmpl

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)
Left Patch Set: Addressed Dave's feedback Created June 4, 2018, 1:21 p.m.
Right Patch Set: Fixed README title Created June 7, 2018, 1:58 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « pages/exceptions/subdocument.tmpl ('k') | pages/filters/blocking.tmpl » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title = $xmlhttprequest Exception 1 title = $xmlhttprequest Exception
2 template = testcase
2 3
3 {% set testcase_moreinfo = [ 4 {% set testcase_moreinfo = [
4 ("Filter Options", "https://adblockplus.org/filters#options"), 5 ("Filter Options", "https://adblockplus.org/filters#options"),
5 ] %} 6 ] %}
6 7
7 <script> 8 <script>
8 function pagelog(message) {
9 var log = document.getElementById("testcase-ex-xmlhttprequest");
10 log.innerText = log.innerText + message + "\n";
11 console.log(message);
12 }
13
14 function aborted(evt) { 9 function aborted(evt) {
15 pagelog("XMLHTTPRequest was aborted."); 10 pagelog("XMLHTTPRequest was aborted.");
16 } 11 }
17 12
18 function failed(evt) { 13 function failed(evt) {
19 pagelog("XMLHTTPRequest failed."); 14 pagelog("XMLHTTPRequest failed.");
20 } 15 }
21 16
22 function makerequest() { 17 function makerequest() {
23 var req = new XMLHttpRequest(); 18 var req = new XMLHttpRequest();
(...skipping 15 matching lines...) Expand all
39 <h2>$xmlhttprequest Exception</h2> 34 <h2>$xmlhttprequest Exception</h2>
40 <p>Check that usage of the $xmlhttprequest filter option in an exception filte r works as expected.</p> 35 <p>Check that usage of the $xmlhttprequest filter option in an exception filte r works as expected.</p>
41 <p>With the filter(s) displayed below each test case added to ABP (or with the testcase subscription installed and active), the XMLHTTPRequest should not be b locked while the image should be.</p> 36 <p>With the filter(s) displayed below each test case added to ABP (or with the testcase subscription installed and active), the XMLHTTPRequest should not be b locked while the image should be.</p>
42 </section> 37 </section>
43 38
44 <section class="site-panel"> 39 <section class="site-panel">
45 <h2>Test case</h2> 40 <h2>Test case</h2>
46 <p>The XMLHTTPRequest should not be blocked. The Image should be blocked.</p> 41 <p>The XMLHTTPRequest should not be blocked. The Image should be blocked.</p>
47 <div class="testcase-container"> 42 <div class="testcase-container">
48 <div class="testcase-row"> 43 <div class="testcase-row">
49 <h3>XMLHTTPRequest</h3><div id="testcase-ex-xmlhttprequest"></div> 44 <h3>XMLHTTPRequest</h3><div id="testcase-output"></div>
50 </div> 45 </div>
51 <div class="testcase-row"> 46 <div class="testcase-row">
52 <h3>Image</h3><img class="testcase-image" src="/testcasefiles/xmlhttpreque stexception/image.jpg"/> 47 <h3>Image</h3><img class="testcase-image" src="/testcasefiles/xmlhttpreque stexception/image.jpg"/>
53 </div> 48 </div>
54 </div> 49 </div>
55 <h3>Filters</h3> 50 <h3>Filters</h3>
56 <pre>||testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/*</pre> 51 <pre>||testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/*</pre>
57 <pre>@@testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/$xmlhtt prequest</pre> 52 <pre>@@testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/$xmlhtt prequest</pre>
58 </section> 53 </section>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld