 Issue 29755578:
  Issue 2148 - Rewrite the testpages test suite  (Closed)
    
  
    Issue 29755578:
  Issue 2148 - Rewrite the testpages test suite  (Closed) 
  | Index: templates/testcase.tmpl | 
| =================================================================== | 
| --- a/templates/testcase.tmpl | 
| +++ b/templates/testcase.tmpl | 
| @@ -3,21 +3,85 @@ | 
| <head> | 
| <title>{{ title }}</title> | 
| <link rel="stylesheet" href="/css/testpages.css"> | 
| + <meta name="viewport" content="width=device-width, initial-scale=1"> | 
| 
kzar
2018/04/19 13:08:25
Nit: Git warned me that you've accidentally put a
 | 
| </head> | 
| <body> | 
| + <? include header ?> | 
| + <div class="site-container"> | 
| + | 
| 
kzar
2018/04/19 13:08:26
Nit: Please could you remove the trailing whitespa
 | 
| + <section class="site-panel site-breadcrumbs"> | 
| + <a href="/" target="_top">Home</a> | 
| 
kzar
2018/04/19 13:08:23
Nit: Git warned me that you've accidentally put a
 | 
| + > <a href="testcases" target="_top">Test cases</a> | 
| 
kzar
2018/04/19 13:08:26
Nit: Git warned me that you've accidentally put a
 | 
| + {{ breadcrumb|safe }} | 
| + </section> | 
| 
kzar
2018/04/19 13:08:25
Nit: Git warned me that you've accidentally put a
 | 
| - <? include header ?> | 
| + {{ body|safe }} | 
| + | 
| + {% if testcase_howtotest_steps or testcase_howtotest_notes %} | 
| + <section class="site-panel"> | 
| + <h2>How to test</h2> | 
| + {% if testcase_howtotest_steps %} | 
| + <h3>Steps</h3> | 
| + <ul> | 
| + {% for step in testcase_howtotest_steps %} | 
| + <li>{{ step }}</li> | 
| + {% endfor %} | 
| + </ul> | 
| + {% endif %} | 
| + {% if testcase_howtotest_notes %} | 
| + <h3>Notes</h3> | 
| + <ul> | 
| + {% for note in testcase_howtotest_notes %} | 
| + <li>{{ note }}</li> | 
| + {% endfor %} | 
| + </ul> | 
| + {% endif %} | 
| + </section> | 
| 
kzar
2018/04/19 13:08:23
Nit: Git warned me that you've accidentally put a
 | 
| + {% endif %} | 
| 
kzar
2018/04/19 13:08:26
Nit: Git warned me that you've accidentally put a
 | 
| + | 
| - <section class="abp-container abp-breadcrumb"> | 
| - <a href="/" target="_top">Home</a> | 
| - > <a href="testcases" target="_top">Test cases</a> | 
| - {{ breadcrumb|safe }} | 
| - </section> | 
| + {% if testcase_filters %} | 
| + <section class="site-panel"> | 
| 
kzar
2018/04/19 13:08:24
Nit: Git warned me that you've accidentally put a
 | 
| + <h2>Example filters</h2> | 
| + <p>Example filters that can be used when testing this page.</p> | 
| + {% for filter in testcase_filters %} | 
| + <div class="testcase-filter"> | 
| + <p class="filter">{{filter[0]}}</p> | 
| + <p class="description">{{filter[1]}}</p> | 
| + </div> | 
| + {%endfor %} | 
| + </section> | 
| 
kzar
2018/04/19 13:08:27
Nit: Git warned me that you've accidentally put a
 | 
| + {% endif %} | 
| 
kzar
2018/04/19 13:08:24
Nit: Git warned me that you've accidentally put a
 | 
| - <section class="abp-container"> | 
| - <h2>Test case - {{ testcaseid }}</h2> | 
| - {{ body|safe }} | 
| - </section> | 
| + {% if testcase_passnotes %} | 
| 
kzar
2018/04/19 13:08:28
Nit: Git warned me that you've accidentally put a
 | 
| + <section class="site-panel"> | 
| + <h2>Pass</h2> | 
| + {% for note in testcase_passnotes %} | 
| + <p>{{ note }}</p> | 
| + {% endfor %} | 
| + </section> | 
| 
kzar
2018/04/19 13:08:24
Nit: Git warned me that you've accidentally put a
 | 
| + {% endif %} | 
| 
kzar
2018/04/19 13:08:27
Nit: Git warned me that you've accidentally put a
 | 
| + | 
| + {% if testcase_moreinfo %} | 
| 
kzar
2018/04/19 13:08:25
Nit: Git warned me that you've accidentally put a
 | 
| + <section class="site-panel"> | 
| 
kzar
2018/04/19 13:08:26
Nit: Git warned me that you've accidentally put a
 | 
| + <h2>More information</h2> | 
| + <ul> | 
| + {% for link in testcase_moreinfo %} | 
| + <li><a href="{{link[1]}}">{{link[0]}}</a></li> | 
| + {%endfor %} | 
| + </ul> | 
| + </section> | 
| 
kzar
2018/04/19 13:08:28
Nit: Git warned me that you've accidentally put a
 | 
| + {% endif %} | 
| 
kzar
2018/04/19 13:08:26
Nit: Git warned me that you've accidentally put a
 | 
| + | 
| + | 
| + | 
| + | 
| + | 
| + </div> | 
| + | 
| 
kzar
2018/04/19 13:08:25
Nit: Please could you remove these extra blank lin
 | 
| + | 
| + | 
| + | 
| <? include footer ?> | 
| 
kzar
2018/04/19 13:08:25
Nit: Please could you remove this tab character? I
 |