Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/filters/blocking.tmpl

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)
Patch Set: Addressed Dave's feedback Created June 4, 2018, 1:21 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pages/filters/blocking.tmpl
===================================================================
--- a/pages/filters/blocking.tmpl
+++ b/pages/filters/blocking.tmpl
@@ -1,4 +1,4 @@
-title = Blocking - ABP Test Pages
+title = Blocking
template = testcase
{% set testcase_moreinfo = [
@@ -8,6 +8,7 @@
<section class="site-panel">
kzar 2018/06/04 17:17:29 I wonder if we should improve the markup a bit so
rossg 2018/06/07 10:30:24 I plan to do this somewhat with the next wave of t
kzar 2018/06/07 11:43:04 Sure, if you want to do this later that's fair eno
<h2>Blocking</h2>
<p>Check that basic blocking functionality is working as expected.</p>
+ <p>With the filter displayed below each test case added to ABP (or with the testcase subscription installed and active), the test images in each test case panel should be blocked.</p>
</section>
<section class="site-panel">
@@ -17,7 +18,7 @@
<div class="testcase-content stripes-grey">Content</div>
</div>
<h3>Filters</h3>
- ||testpages.adblockplus.org/testcasefiles/blocking/addresscomplete/image.jpg
+ <pre>||testpages.adblockplus.org/testcasefiles/blocking/addresscomplete/image.jpg</pre>
</section>
<section class="site-panel">
@@ -27,7 +28,7 @@
<div class="testcase-content stripes-grey">Content</div>
</div>
<h3>Filters</h3>
- /testcasefiles/blocking/addresspart/abptestcasepath/
+ <pre>/testcasefiles/blocking/addresspart/abptestcasepath/</pre>
</section>
<section class="site-panel">
@@ -38,5 +39,5 @@
<div class="testcase-content stripes-grey">Content</div>
</div>
<h3>Filters</h3>
- ||testpages.adblockplus.org/testcasefiles/blocking/wildcard/*/image.jpg
+ <pre>||testpages.adblockplus.org/testcasefiles/blocking/wildcard/*/image.jpg</pre>
</section>

Powered by Google App Engine
This is Rietveld