Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/filters/object-subrequest.tmpl

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)
Patch Set: Addressed Dave's feedback Created June 4, 2018, 1:21 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pages/filters/object-subrequest.tmpl
===================================================================
--- a/pages/filters/object-subrequest.tmpl
+++ b/pages/filters/object-subrequest.tmpl
@@ -1,4 +1,4 @@
-title = $object-subrequest - ABP Test Pages
+title = $object-subrequest
template = testcase
{% set testcase_moreinfo = [
@@ -8,18 +8,21 @@
<section class="site-panel">
<h2>$object-subrequest</h2>
<p>Check that usage of the $object-subrequest filter option works as expected.</p>
+ <p>With the filter displayed below each test case added to ABP (or with the testcase subscription installed and active), the object/swf file and image should not be blocked, but the request from the object/swf file should be.</p>
</section>
<section class="site-panel">
<h2>Test case</h2>
<div class="testcase-container">
<div class="testcase-row">
- <h3>Object Subrequest</h3><object data="/testcasefiles/objectsubrequest/objectsubrequest.swf" type="application/x-shockwave-flash" style="width: 250px; height: 250px;"></object>
+ <h3>Object Subrequest</h3>
+ <object data="/testcasefiles/objectsubrequest/objectsubrequest.swf" type="application/x-shockwave-flash" style="width: 250px; height: 250px;"></object>
</div>
<div class="testcase-row">
- <h3>Image</h3><img class="testcase-image" src="/testcasefiles/objectsubrequest/image.jpg"/>
+ <h3>Image</h3>
+ <img class="testcase-image" src="/testcasefiles/objectsubrequest/image.jpg"/>
</div>
</div>
<h3>Filters</h3>
- testpages.adblockplus.org/testcasefiles/objectsubrequest/$object-subrequest
+ <pre>testpages.adblockplus.org/testcasefiles/objectsubrequest/$object-subrequest</pre>
</section>

Powered by Google App Engine
This is Rietveld