Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/filters/webrtc.tmpl

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)
Patch Set: Addressed Dave's feedback Created June 4, 2018, 1:21 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pages/filters/webrtc.tmpl
===================================================================
--- a/pages/filters/webrtc.tmpl
+++ b/pages/filters/webrtc.tmpl
@@ -1,4 +1,4 @@
-title = $webrtc - ABP Test Pages
+title = $webrtc
template = testcase
{% set testcase_moreinfo = [
@@ -23,7 +23,7 @@
function handleLocalAddCandidateSuccess() {
pagelog("handleLocalAddCandidateSuccess()")
}
-
+
function handleRemoteAddCandidateSuccess() {
pagelog("handleRemoteAddCandidateSuccess()")
}
@@ -37,7 +37,7 @@
function handleSendChannelStatusChange(event) {
if (sendChannel) {
var state = sendChannel.readyState;
-
+
if (state === "open") {
pagelog("handleSendChannelStatusChange() open")
sendChannel.send("Test Message");
@@ -87,6 +87,8 @@
<section class="site-panel">
<h2>$webrtc</h2>
<p>Check that usage of the $webrtc filter option works as expected.</p>
+ <p>With the filter displayed below each test case added to ABP (or with the testcase subscription installed and active), the WebRTC connection should be blocked.</p>
+ <p>Note: This test does not work correctly yet.</p>
</section>
<section class="site-panel">
@@ -97,5 +99,5 @@
</div>
</div>
<h3>Filters</h3>
- $webrtc,domain=testpages.adblockplus.org
+ <pre>$webrtc,domain=testpages.adblockplus.org</pre>
</section>

Powered by Google App Engine
This is Rietveld