Issue 29755927: Noissue - Have sitemap sort output by page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29755927: Noissue - Have sitemap sort output by page (Closed)

Created:
April 19, 2018, 3:37 a.m. by rosie

Modified:
May 1, 2018, 6:46 p.m.

Reviewers:
Sebastian Noack, Vasily Kuznetsov, Jon Sonesen

Base URL:
https://hg.adblockplus.org/cms/

Visibility:
Public.

Description

Noissue - Have sitemap sort output by page

Patch Set 1 #

Created: April 19, 2018, 3:37 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	tests/expected_output/en/sitemap	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/test_site/pages/sitemap.tmpl	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Vasily Kuznetsov

LGTM. I wonder if maybe `get_pages_metadata` should just sort everything this way to always produce ...

April 19, 2018, 3:32 p.m. (2018-04-19 15:32:19 UTC) #3

Sebastian Noack

On 2018/04/19 15:32:19, Vasily Kuznetsov wrote: > I wonder if maybe `get_pages_metadata` should just sort ...

April 19, 2018, 9:41 p.m. (2018-04-19 21:41:10 UTC) #4

Vasily Kuznetsov

On 2018/04/19 21:41:10, Sebastian Noack wrote: > On 2018/04/19 15:32:19, Vasily Kuznetsov wrote: > > ...

April 20, 2018, 10:20 a.m. (2018-04-20 10:20:22 UTC) #5

Jon Sonesen

April 21, 2018, 12:23 a.m. (2018-04-21 00:23:40 UTC) #6

On 2018/04/20 10:20:22, Vasily Kuznetsov wrote:
> On 2018/04/19 21:41:10, Sebastian Noack wrote:
> > On 2018/04/19 15:32:19, Vasily Kuznetsov wrote:
> > > I wonder if maybe `get_pages_metadata` should just sort everything this
way
> to
> > > always produce deterministic order. What do you guys think?
> > 
> > I think its not worth it. In a real-world scenario it would make more sense
to
> > sort by the visible title (or some other metadata), not by an internal
> > identifier like here.
> 
> Yeah, makes sense. Allright, let's not sort it.

LGTM

Expand All Messages | Collapse All Messages