tox.ini - Issue 29756669: Noissue - Adapt best practices for trailing commas (python-abp)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: tox.ini

Issue 29756669: Noissue - Adapt best practices for trailing commas (python-abp) (Closed)

Left Patch Set: Created April 19, 2018, 12:55 p.m.

Right Patch Set: Re-run script on Python 2, added flake8-commas extension Created April 19, 2018, 2:44 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 [tox]	1 [tox]

2 envlist = py27,py35,py36,pypy,coverage,flake8	2 envlist = py27,py35,py36,pypy,coverage,flake8

3	3

4 [testenv]	4 [testenv]

5 deps =	5 deps =

6 pytest	6 pytest

7 mock	7 mock

8 commands =	8 commands =

9 py.test tests	9 py.test tests

10	10

11 [testenv:coverage]	11 [testenv:coverage]

12 deps =	12 deps =

13 pytest-cov	13 pytest-cov

14 mock	14 mock

15 commands =	15 commands =

16 py.test --cov=abp --cov-report=term-missing tests	16 py.test --cov=abp --cov-report=term-missing tests

17	17

18 # We have to install our package in development mode	18 # We have to install our package in development mode

19 # so that pytest-cov can find the .coverage file.	19 # so that pytest-cov can find the .coverage file.

20 usedevelop = true	20 usedevelop = true

21	21

22 [testenv:flake8]	22 [testenv:flake8]

23 basepython = python3	23 basepython = python3

24 skip_install = true	24 skip_install = true

25 deps =	25 deps =

26 flake8	26 flake8

27 flake8-docstrings	27 flake8-docstrings

	28 flake8-commas

28 pep8-naming	29 pep8-naming

29 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo	30 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo

30 commands =	31 commands =

31 flake8 --ignore=D107 abp	32 flake8 --ignore=D107 abp

32 flake8 --ignore=D1 tests setup.py	33 flake8 --ignore=D1 tests setup.py

LEFT	RIGHT