Noissue - Adapt best practices for trailing commas (buildtools)

build.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import argparse
 import logging
 import os
 import re
 import shutil
 import subprocess
@@ skipping 118 matching lines @@
             '-b', '--build-num', dest='build_num',
             help='Use given build number (if omitted the build number will '
                  'be retrieved from Mercurial)'),
         make_argument(
             '-k', '--key', dest='key_file',
             help='File containing private key and certificates required to '
                   'sign the package'),
         make_argument(
             '-r', '--release', action='store_true',
             help='Create a release build'),
-        make_argument('output_file', nargs='?')
-    )
+        make_argument('output_file', nargs='?'),
+    ),
 )
 def build(base_dir, build_num, key_file, release, output_file, platform,
           **kwargs):
     """
     Create a build.
 
     Creates an extension build with given file name. If output_file is missing
     a default name will be chosen.
     """
     kwargs = {}
     if platform == 'edge':
         import buildtools.packagerEdge as packager
     else:
         import buildtools.packagerChrome as packager
 
     kwargs['keyFile'] = key_file
     kwargs['outFile'] = output_file
     kwargs['releaseBuild'] = release
     kwargs['buildNum'] = build_num
 
     packager.createBuild(base_dir, type=platform, **kwargs)
 
 
 @argparse_command(
-    valid_platforms={'chrome', 'gecko', 'edge'}
+    valid_platforms={'chrome', 'gecko', 'edge'},
 )
 def devenv(base_dir, platform, **kwargs):
     """
     Set up a development environment.
 
     Will set up or update the devenv folder as an unpacked extension folder '
     for development.
     """
     if platform == 'edge':
         import buildtools.packagerEdge as packager
     else:
         import buildtools.packagerChrome as packager
 
     file = StringIO()
     packager.createBuild(base_dir, type=platform, outFile=file, devenv=True,
                          releaseBuild=True)
 
     from buildtools.packager import getDevEnvPath
     devenv_dir = getDevEnvPath(base_dir, platform)
 
     shutil.rmtree(devenv_dir, ignore_errors=True)
 
     file.seek(0)
     with ZipFile(file, 'r') as zip_file:
         zip_file.extractall(devenv_dir)
 
 
 project_key_argument = make_argument(
-    'project_key', help='The crowdin project key.'
+    'project_key', help='The crowdin project key.',
 )
 
 
 @argparse_command(
-    arguments=(project_key_argument, )
+    arguments=(project_key_argument,),
 )
 def setuptrans(base_dir, project_key, platform, **kwargs):
     """
     Set up translation languages.
 
     Set up translation languages for the project on crowdin.com.
     """
     from buildtools.packager import readMetadata
     metadata = readMetadata(base_dir, platform)
 
     basename = metadata.get('general', 'basename')
     locale_config = read_locale_config(base_dir, platform, metadata)
 
     import buildtools.localeTools as localeTools
     localeTools.setupTranslations(locale_config, basename, project_key)
 
 
 @argparse_command(
-    arguments=(project_key_argument, )
+    arguments=(project_key_argument,),
 )
 def translate(base_dir, project_key, platform, **kwargs):
     """
     Update translation master files.
 
     Update the translation master files in the project on crowdin.com.
     """
     from buildtools.packager import readMetadata
     metadata = readMetadata(base_dir, platform)
 
     basename = metadata.get('general', 'basename')
     locale_config = read_locale_config(base_dir, platform, metadata)
 
     default_locale_dir = os.path.join(locale_config['base_path'],
                                       locale_config['default_locale'])
 
     import buildtools.localeTools as localeTools
     localeTools.updateTranslationMaster(locale_config, metadata,
                                         default_locale_dir, basename,
                                         project_key)
 
 
 @argparse_command(
-    arguments=(project_key_argument, )
+    arguments=(project_key_argument,),
 )
 def uploadtrans(base_dir, project_key, platform, **kwargs):
     """
     Upload existing translations.
 
     Upload already existing translations to the project on crowdin.com.
     """
     from buildtools.packager import readMetadata
     metadata = readMetadata(base_dir, platform)
 
     basename = metadata.get('general', 'basename')
     locale_config = read_locale_config(base_dir, platform, metadata)
 
     import buildtools.localeTools as localeTools
     for locale, locale_dir in locale_config['locales'].iteritems():
         if locale != locale_config['default_locale'].replace('_', '-'):
             localeTools.uploadTranslations(locale_config, metadata, locale_dir,
                                            locale, basename, project_key)
 
 
 @argparse_command(
-    arguments=(project_key_argument, )
+    arguments=(project_key_argument,),
 )
 def gettranslations(base_dir, project_key, platform, **kwargs):
     """
     Download translation updates.
 
     Download updated translations from crowdin.com.
     """
     from buildtools.packager import readMetadata
     metadata = readMetadata(base_dir, platform)
 
     basename = metadata.get('general', 'basename')
     locale_config = read_locale_config(base_dir, platform, metadata)
 
     import buildtools.localeTools as localeTools
     localeTools.getTranslations(locale_config, basename, project_key)
 
 
 @argparse_command(
     valid_platforms={'chrome'},
     arguments=(
         make_argument('target_dir'),
         make_argument('-q', '--quiet', help='Suppress JsDoc output',
                       action='store_true', default=False),
-    )
+    ),
 )
 def docs(base_dir, target_dir, quiet, platform, **kwargs):
     """
     Generate documentation (requires node.js).
 
     Generate documentation files and write them into the specified directory.
     """
     source_dir = os.path.join(base_dir, 'lib')
 
     # JSDoc struggles wih huge objects:
@@ skipping 32 matching lines @@
         make_argument(
             '-k', '--key', dest='key_file',
             help='File containing private key and certificates required to '
                   'sign the release.'),
         make_argument(
             '-d', '--downloads-repository', dest='downloads_repository',
             help='Directory containing downloads repository (if omitted '
                   '../downloads is assumed)'),
         make_argument(
             'version', help='Version number of the release',
-            type=valid_version_format)
-    )
+            type=valid_version_format),
+    ),
 )
 def release(base_dir, downloads_repository, key_file, platform, version,
             **kwargs):
     """
     Run release automation.
 
     Note: If you are not the project owner then you probably don't want to run
     this!
 
     Run release automation: create downloads for the new version, tag source
@@ skipping 26 matching lines @@
     if build_available_subcommands(base_dir):
         MAIN_PARSER.set_defaults(base_dir=base_dir)
 
         # If no args are provided, this module is run directly from the command
         # line. argparse will take care of consuming sys.argv.
         arguments = MAIN_PARSER.parse_args(args if len(args) > 0 else None)
 
         function = arguments.function
         del arguments.function
         function(**vars(arguments))