tox.ini - Issue 29756673: Noissue - Adapt best practices for trailing commas (buildtools)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: tox.ini

Issue 29756673: Noissue - Adapt best practices for trailing commas (buildtools) (Closed)

Left Patch Set: Created April 19, 2018, 12:58 p.m.

Right Patch Set: Re-run script on Python 2, added flake8-commas extension Created April 19, 2018, 2:09 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 [tox]	1 [tox]

2 envlist = py27	2 envlist = py27

3 skipsdist = true	3 skipsdist = true

4	4

5 [flake8]	5 [flake8]

6 ignore = D1	6 ignore = D1,C815
	Sebastian Noack 2018/04/19 14:11:26 C185 are commas after varargs which are a syntax e C185 are commas after varargs which are a syntax error in Python 2.
7 per-file-ignores =	7 per-file-ignores =

8 /chainedconfigparser.py : A107,E501,D205,D208,D400	8 /chainedconfigparser.py : A107,E501,D205,D208,D400

9 /ensure_dependencies.py : A102,A107,A108,D400,A302,E129,E501,E713,E721,F821	9 /ensure_dependencies.py : A102,A107,A108,D400,A302,E129,E501,E713,E721,F821

10 /localeTools.py : A104,A107,A301,A302,E501,E713,F401,N802,N803,N806	10 /localeTools.py : A104,A107,A301,A302,E501,E713,F401,N802,N803,N806

11 /packager.py : A102,A107,A206,A302,E501,E711,N802,N803,N806	11 /packager.py : A102,A107,A206,A302,E501,E711,N802,N803,N806

12 /packagerChrome.py : A101,A104,A107,A112,A302,E501,E711,F841,N802,N803,N806	12 /packagerChrome.py : A101,A104,A107,A112,A302,E501,E711,F841,N802,N803,N806

13 /publicSuffixListUpdater.py : A108,D200,D202,D205,D400,D401,D403,E501,F821,N 802,N803	13 /publicSuffixListUpdater.py : A108,D200,D202,D205,D400,D401,D403,E501,F821,N 802,N803

14 /releaseAutomation.py : A102,A107,A108,D202,D400,D401,E501,F401,N803,N806	14 /releaseAutomation.py : A102,A107,A108,D202,D400,D401,E501,F401,N803,N806

15	15

16 [coverage:run]	16 [coverage:run]

17 omit = tests/*	17 omit = tests/*

18	18

19 [coverage:report]	19 [coverage:report]

20 show_missing = True	20 show_missing = True

21	21

22 [testenv]	22 [testenv]

23 whitelist_externals = npm	23 whitelist_externals = npm

24 setenv =	24 setenv =

25 PYTHONPATH = {toxinidir}/..	25 PYTHONPATH = {toxinidir}/..

26 deps =	26 deps =

27 pycrypto	27 pycrypto

28 pytest	28 pytest

29 pytest-cov	29 pytest-cov

30 jinja2	30 jinja2

31 flake8	31 flake8

32 flake8-per-file-ignores>=0.4	32 flake8-per-file-ignores>=0.4

33 flake8-docstrings	33 flake8-docstrings

	34 flake8-commas

34 pep8-naming	35 pep8-naming

35 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo	36 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo

36 commands =	37 commands =

37 npm install --no-package-lock --only=production	38 npm install --no-package-lock --only=production

38 pytest tests --capture=sys --cov=buildtools	39 pytest tests --capture=sys --cov=buildtools

39 flake8	40 flake8

LEFT	RIGHT