Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: build.py

Issue 29756673: Noissue - Adapt best practices for trailing commas (buildtools) (Closed)
Patch Set: Re-run script on Python 2, added flake8-commas extension Created April 19, 2018, 2:09 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chainedconfigparser.py » ('j') | tox.ini » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build.py
===================================================================
--- a/build.py
+++ b/build.py
@@ -136,8 +136,8 @@
make_argument(
'-r', '--release', action='store_true',
help='Create a release build'),
- make_argument('output_file', nargs='?')
- )
+ make_argument('output_file', nargs='?'),
+ ),
)
def build(base_dir, build_num, key_file, release, output_file, platform,
**kwargs):
@@ -162,7 +162,7 @@
@argparse_command(
- valid_platforms={'chrome', 'gecko', 'edge'}
+ valid_platforms={'chrome', 'gecko', 'edge'},
)
def devenv(base_dir, platform, **kwargs):
"""
@@ -191,12 +191,12 @@
project_key_argument = make_argument(
- 'project_key', help='The crowdin project key.'
+ 'project_key', help='The crowdin project key.',
)
@argparse_command(
- arguments=(project_key_argument, )
+ arguments=(project_key_argument,),
)
def setuptrans(base_dir, project_key, platform, **kwargs):
"""
@@ -215,7 +215,7 @@
@argparse_command(
- arguments=(project_key_argument, )
+ arguments=(project_key_argument,),
)
def translate(base_dir, project_key, platform, **kwargs):
"""
@@ -239,7 +239,7 @@
@argparse_command(
- arguments=(project_key_argument, )
+ arguments=(project_key_argument,),
)
def uploadtrans(base_dir, project_key, platform, **kwargs):
"""
@@ -261,7 +261,7 @@
@argparse_command(
- arguments=(project_key_argument, )
+ arguments=(project_key_argument,),
)
def gettranslations(base_dir, project_key, platform, **kwargs):
"""
@@ -285,7 +285,7 @@
make_argument('target_dir'),
make_argument('-q', '--quiet', help='Suppress JsDoc output',
action='store_true', default=False),
- )
+ ),
)
def docs(base_dir, target_dir, quiet, platform, **kwargs):
"""
@@ -338,8 +338,8 @@
'../downloads is assumed)'),
make_argument(
'version', help='Version number of the release',
- type=valid_version_format)
- )
+ type=valid_version_format),
+ ),
)
def release(base_dir, downloads_repository, key_file, platform, version,
**kwargs):
« no previous file with comments | « no previous file | chainedconfigparser.py » ('j') | tox.ini » ('J')

Powered by Google App Engine
This is Rietveld