Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: tests/test_packagerWebExt.py

Issue 29756673: Noissue - Adapt best practices for trailing commas (buildtools) (Closed)
Patch Set: Re-run script on Python 2, added flake8-commas extension Created April 19, 2018, 2:09 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/test_packagerEdge.py ('k') | tox.ini » ('j') | tox.ini » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/test_packagerWebExt.py
===================================================================
--- a/tests/test_packagerWebExt.py
+++ b/tests/test_packagerWebExt.py
@@ -24,8 +24,8 @@
'test.Foobar': {
'message': 'Ensuring dict-copy from modules for $domain$',
'description': 'test description',
- 'placeholders': {'content': '$1', 'example': 'www.adblockplus.org'}
- }
+ 'placeholders': {'content': '$1', 'example': 'www.adblockplus.org'},
+ },
}
ALL_LANGUAGES = ['en_US', 'de', 'it']
@@ -36,7 +36,7 @@
'description': {
'message': 'Adblock Plus is the most popular ad blocker ever, '
'and also supports websites by not blocking '
- 'unobstrusive ads by default (configurable).'
+ 'unobstrusive ads by default (configurable).',
},
})
@@ -242,7 +242,7 @@
qunit_dir.join('common.js').write(files['qunit/common.js'])
qunit_tests_dir = qunit_dir.mkdir('tests')
qunit_tests_dir.join('some_test.js').write(
- files['qunit/tests/some_test.js']
+ files['qunit/tests/some_test.js'],
)
return files
@@ -252,7 +252,7 @@
if isinstance(json_data, basestring):
json_data = json.loads(json_data)
return json.dumps(
- json_data, sort_keys=True, indent=0
+ json_data, sort_keys=True, indent=0,
).split('\n')
@@ -324,7 +324,7 @@
assert '../ext/background.js' in quint_index
assert set(manifest['background']['scripts']) == set(
- scripts + ['devenvPoller__.js']
+ scripts + ['devenvPoller__.js'],
)
else:
assert set(manifest['background']['scripts']) == set(scripts)
@@ -421,7 +421,7 @@
filenames = {
'gecko': 'adblockplusfirefox-1.2.3{}.xpi',
'chrome': 'adblockpluschrome-1.2.3{{}}.{}'.format(
- {True: 'crx', False: 'zip'}[release]
+ {True: 'crx', False: 'zip'}[release],
),
'edge': 'adblockplusedge-1.2.3{}.appx',
}
« no previous file with comments | « tests/test_packagerEdge.py ('k') | tox.ini » ('j') | tox.ini » ('J')

Powered by Google App Engine
This is Rietveld