metadata.chrome - Issue 29756688: Issue 6567 - Update buildtools to 47429f8d9b6a

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.chrome

Issue 29756688: Issue 6567 - Update buildtools to 47429f8d9b6a (Closed)

Left Patch Set: Created April 19, 2018, 1:08 p.m.

Right Patch Set: NOCHANGE rebase against `next` (0dd150989c28) Created April 20, 2018, 7:36 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 basename = adblockpluschrome	2 basename = adblockpluschrome

3 version = 3.0.3	3 version = 3.0.2

4 author = eyeo GmbH	4 author = eyeo GmbH

5 backgroundScripts = polyfill.js	5 backgroundScripts = polyfill.js

6 ext/common.js	6 ext/common.js

7 ext/background.js	7 ext/background.js

8 lib/compat.js	8 lib/compat.js

9 lib/publicSuffixList.js	9 lib/publicSuffixList.js

10 lib/adblockplus.js	10 lib/adblockplus.js

11 testScripts = ../polyfill.js	11 testScripts = ../polyfill.js

12 ../ext/common.js	12 ../ext/common.js

13 ../ext/background.js	13 ../ext/background.js

(...skipping 22 matching lines...) Expand all Loading...
36 permissions =	36 permissions =

37 tabs	37 tabs

38 <all_urls>	38 <all_urls>

39 contextMenus	39 contextMenus

40 webRequest	40 webRequest

41 webRequestBlocking	41 webRequestBlocking

42 webNavigation	42 webNavigation

43 storage	43 storage

44 unlimitedStorage	44 unlimitedStorage

45 notifications	45 notifications

46
Sebastian Noack 2018/04/19 13:19:54 Nit: Two blank lines between sections is inconsist Nit: Two blank lines between sections is inconsistent with the rest of the file. tlucas 2018/04/19 13:26:17 Done. Show quoted text On 2018/04/19 13:19:54, Sebastian Noack wrote: > Nit: Two blank lines between sections is inconsistent with the rest of the file. Done.
47	46

48 [compat]	47 [compat]

49 chrome = 49.0	48 chrome = 49.0

50 opera = 36.0	49 opera = 36.0

51	50

52 [contentScripts]	51 [contentScripts]

53 document_start =	52 document_start =

54 polyfill.js	53 polyfill.js

55 ext/common.js	54 ext/common.js

56 ext/content.js	55 ext/content.js

(...skipping 86 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
143 adblockpluscore/lib/synchronizer.js	142 adblockpluscore/lib/synchronizer.js

144 lib/requestBlocker.js	143 lib/requestBlocker.js

145 lib/popupBlocker.js	144 lib/popupBlocker.js

146 lib/subscriptionInit.js	145 lib/subscriptionInit.js

147 lib/filterComposer.js	146 lib/filterComposer.js

148 lib/stats.js	147 lib/stats.js

149 lib/uninstall.js	148 lib/uninstall.js

150 lib/csp.js	149 lib/csp.js

151 lib/cssInjection.js	150 lib/cssInjection.js

152 adblockplusui/messageResponder.js	151 adblockplusui/messageResponder.js

153 background.js

154 include.preload.js =	152 include.preload.js =

155 include.preload.js	153 include.preload.js

156 inject.preload.js	154 inject.preload.js

157 include.postload.js = subscriptionLink.postload.js	155 include.postload.js =
Sebastian Noack 2018/04/19 13:19:54 Nit: Any reason to not move the first item to the Nit: Any reason to not move the first item to the next line here as well? tlucas 2018/04/19 13:26:17 Not at all - changed it. Show quoted text On 2018/04/19 13:19:54, Sebastian Noack wrote: > Nit: Any reason to not move the first item to the next line here as well? Not at all - changed it.
	156 subscriptionLink.postload.js

158 composer.postload.js	157 composer.postload.js

159 qunit/tests.js =	158 qunit/tests.js =

160 qunit/common.js	159 qunit/common.js

161 qunit/tests/prefs.js	160 qunit/tests/prefs.js

162 qunit/tests/url.js	161 qunit/tests/url.js

163 qunit/tests/cssEscaping.js	162 qunit/tests/cssEscaping.js

164	163

165 [import_locales]	164 [import_locales]

166 adblockplusui/locale//antiadblockInit.json =	165 adblockplusui/locale//antiadblockInit.json =

167 adblockplusui/locale//common.json =	166 adblockplusui/locale//common.json =

168 adblockplusui/locale//desktop-options.json =	167 adblockplusui/locale//desktop-options.json =

169 adblockplusui/locale//firstRun.json =	168 adblockplusui/locale//firstRun.json =

170 adblockplusui/locale//issue-reporter.json =	169 adblockplusui/locale//issue-reporter.json =

171 adblockplusui/locale//updates.json =	170 adblockplusui/locale//updates.json =

LEFT	RIGHT