cms/bin/translate.py - Issue 29756692: Noissue - Adapt best practices for trailing commas (cms)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: cms/bin/translate.py

Issue 29756692: Noissue - Adapt best practices for trailing commas (cms) (Closed)

Patch Set: More cleanup, added flake8-commas extension Created April 19, 2018, 2:19 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: cms/bin/translate.py

===================================================================

--- a/cms/bin/translate.py

+++ b/cms/bin/translate.py

@@ -45,7 +45,7 @@

url = '/api/project/%s/%s?%s' % (

urllib.quote(self.project_name),

urllib.quote(api_endpoint),

- urllib.urlencode((('key', self.api_key),) + query_params)

+ urllib.urlencode((('key', self.api_key),) + query_params),

)

try:

response = self.connection.request(

@@ -72,7 +72,7 @@

response = self.raw_request(

request_method, api_endpoint, (('json', '1'),),

- fields=fields, preload_content=False

+ fields=fields, preload_content=False,

)

try:

@@ -148,7 +148,7 @@

logger.info('Enabling the required locales for the Crowdin project...')

crowdin_api.request(

'POST', 'edit-project',

- data={'languages': enabled_locales | required_crowdin_locales}

+ data={'languages': enabled_locales | required_crowdin_locales},

)

return required_locales

« no previous file with comments | « no previous file | cms/converters.py » ('j') | no next file with comments »