Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29756797: Fixes #47 - Add link beneath install button to download page (Closed)

Created:
April 19, 2018, 3:30 p.m. by ire
Modified:
April 23, 2018, 1:50 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Fixes #47 - Add link beneath install button to download page

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M includes/hero-download.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M static/css/index.css View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
ire
April 19, 2018, 3:30 p.m. (2018-04-19 15:30:28 UTC) #1
juliandoucette
LGTM + NITs https://codereview.adblockplus.org/29756797/diff/29756798/includes/hero-download.html File includes/hero-download.html (right): https://codereview.adblockplus.org/29756797/diff/29756798/includes/hero-download.html#newcode21 includes/hero-download.html:21: <small> TOL: Not sure if `small` ...
April 23, 2018, 10:35 a.m. (2018-04-23 10:35:52 UTC) #2
ire
April 23, 2018, 1:49 p.m. (2018-04-23 13:49:40 UTC) #3
On 2018/04/23 10:35:52, juliandoucette wrote:
> LGTM + NITs
> 
>
https://codereview.adblockplus.org/29756797/diff/29756798/includes/hero-downl...
> File includes/hero-download.html (right):
> 
>
https://codereview.adblockplus.org/29756797/diff/29756798/includes/hero-downl...
> includes/hero-download.html:21: <small>
> TOL: Not sure if `small` fits here (semantically) (I lean towards no)
> 
>
https://codereview.adblockplus.org/29756797/diff/29756798/includes/hero-downl...
> includes/hero-download.html:22: <a href="download">{{
> download-another-browser[link] Download Adblock Plus for another browser
}}</a>
> Missing period.

Thanks, done.

Powered by Google App Engine
This is Rietveld