Delta Between Two Patch Sets: build.gradle
Issue 29757571:
Issue 6591 - Bundle ABP for Samsung Internet China with Easylist for China (Closed)
Left Patch Set:
Created April 20, 2018, 1:27 p.m.
Right Patch Set: Adjustments regarding Anton's comments
Created April 20, 2018, 3:13 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« adblockplussbrowser/src/test/java/org/adblockplus/sbrowser/contentblocker/engine/UtilsTest.kt ('k')
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 buildscript { | 1 buildscript { |
| 2 // buildscript block is evaluated at the very beginning. Properties defined in the ext block | 2 // buildscript block is evaluated at the very beginning. Properties defined in the ext block |
| 3 // don't exist at that time. | 3 // don't exist at that time. |
| 4 ext.kotlinVersion = '1.2.31' | 4 ext.kotlinVersion = '1.2.31' |
| 5 repositories { | 5 repositories { |
| 6 google() | 6 google() |
| 7 jcenter() | 7 jcenter() |
| 8 } | 8 } |
| 9 dependencies { | 9 dependencies { |
| 10 classpath 'com.android.tools.build:gradle:3.0.1' | 10 classpath 'com.android.tools.build:gradle:3.0.1' |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 21 | 21 |
| 22 ext { | 22 ext { |
| 23 minSdkVersion = 21 | 23 minSdkVersion = 21 |
| 24 targetSdkVersion = 27 | 24 targetSdkVersion = 27 |
| 25 compileSdkVersion = 27 | 25 compileSdkVersion = 27 |
| 26 buildToolsVersion = '27.0.3' | 26 buildToolsVersion = '27.0.3' |
| 27 androidSupportLibraryVersion = '27.1.0' | 27 androidSupportLibraryVersion = '27.1.0' |
| 28 sourceCompatibilityVersion = JavaVersion.VERSION_1_7 | 28 sourceCompatibilityVersion = JavaVersion.VERSION_1_7 |
| 29 targetCompatibilityVersion = JavaVersion.VERSION_1_7 | 29 targetCompatibilityVersion = JavaVersion.VERSION_1_7 |
| 30 easyListDefaultUpdateUrl = 'https://easylist-downloads.adblockplus.org/easyl ist.txt' | 30 easyListDefaultUpdateUrl = 'https://easylist-downloads.adblockplus.org/easyl ist.txt' |
| 31 easyListChinaUpdateUrl = ' https://easylist-downloads.adblockplus.org/easyli stchina+easylistchina_compliance+easylist.txt' | 31 easyListChinaUpdateUrl = 'https://easylist-downloads.adblockplus.org/easylis tchina+easylistchina_compliance+easylist.txt' |
|
anton
2018/04/20 14:03:20
not required space here? does it work with space?
diegocarloslima
2018/04/20 14:48:53
Nice catch! The weird thing is that it worked...
| |
| 32 exceptionRulesUpdateUrl = 'https://easylist-downloads.adblockplus.org/except ionrules.txt' | 32 exceptionRulesUpdateUrl = 'https://easylist-downloads.adblockplus.org/except ionrules.txt' |
| 33 easyListFilePath = file('adblockplussbrowser/res/raw/easylist.txt').absolute Path | 33 easyListFilePath = file('adblockplussbrowser/res/raw/easylist.txt').absolute Path |
| 34 exceptionRulesFilePath = file('adblockplussbrowser/res/raw/exceptionrules.tx t').absolutePath | 34 exceptionRulesFilePath = file('adblockplussbrowser/res/raw/exceptionrules.tx t').absolutePath |
| 35 } | 35 } |
| LEFT | RIGHT |
« adblockplussbrowser/src/test/java/org/adblockplus/sbrowser/contentblocker/engine/UtilsTest.kt ('k')
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
