Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29757584: Issue 6562 - Remove the unused provideFilterKeys parameter (Closed)

Created:
April 20, 2018, 6:41 p.m. by kzar
Modified:
April 23, 2018, 11:06 a.m.
Reviewers:
Manish Jethani
CC:
sergei
Visibility:
Public.

Description

Issue 6562 - Remove the unused provideFilterKeys parameter

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -57 lines) Patch
M lib/elemHide.js View 9 chunks +8 lines, -49 lines 0 comments Download
M test/elemHide.js View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
April 20, 2018, 6:42 p.m. (2018-04-20 18:42:57 UTC) #1
Manish Jethani
https://codereview.adblockplus.org/29757584/diff/29757585/test/elemHide.js File test/elemHide.js (left): https://codereview.adblockplus.org/29757584/diff/29757585/test/elemHide.js#oldcode50 test/elemHide.js:50: // Test without filter keys We should remove this ...
April 20, 2018, 9:08 p.m. (2018-04-20 21:08:29 UTC) #2
kzar
Patch Set 2 : Removed comment https://codereview.adblockplus.org/29757584/diff/29757585/test/elemHide.js File test/elemHide.js (left): https://codereview.adblockplus.org/29757584/diff/29757585/test/elemHide.js#oldcode50 test/elemHide.js:50: // Test without ...
April 23, 2018, 10:23 a.m. (2018-04-23 10:23:37 UTC) #3
Manish Jethani
April 23, 2018, 10:28 a.m. (2018-04-23 10:28:54 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld