Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29758555: Issue 6607 - Update adblockpluscore dependency to revision d7d51d29aa34 (Closed)

Created:
April 22, 2018, 11:30 a.m. by Manish Jethani
Modified:
April 23, 2018, 10:35 a.m.
Reviewers:
Sebastian Noack, kzar
CC:
hub
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 6607 - Update adblockpluscore dependency to revision d7d51d29aa34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Manish Jethani
April 22, 2018, 11:30 a.m. (2018-04-22 11:30:28 UTC) #1
Manish Jethani
Patch Set 1
April 22, 2018, 11:30 a.m. (2018-04-22 11:30:48 UTC) #2
Sebastian Noack
Looks good to me. Just one question, are there any upcoming changes to be landed ...
April 22, 2018, 5:51 p.m. (2018-04-22 17:51:55 UTC) #3
kzar
April 23, 2018, 9 a.m. (2018-04-23 09:00:08 UTC) #4
LGTM

> ...if so, I might prefer to wait and combine them in one 
> dependency update.

Well IMO Manish already did all the work required for a dependency update here,
so we might as well do it now. I don't see much benefit waiting, if we have more
changes to include we can include them but otherwise we'll be testing this work
sooner.

Powered by Google App Engine
This is Rietveld