Issue 6599 - Hotfix to drop updated page everywhere

lib/subscriptionInit.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 12 matching lines @@
        DownloadableSubscription,
        SpecialSubscription} =
   require("../adblockpluscore/lib/subscriptionClasses");
 const {FilterStorage} = require("../adblockpluscore/lib/filterStorage");
 const {FilterNotifier} = require("../adblockpluscore/lib/filterNotifier");
 const info = require("../buildtools/info");
 const {Prefs} = require("./prefs");
 const {Synchronizer} = require("../adblockpluscore/lib/synchronizer");
 const {Utils} = require("./utils");
 const {initNotifications} = require("./notificationHelper");
-const {updatesVersion} = require("../adblockplusui/lib/prefs");
 
 let firstRun;
 let subscriptionsCallback = null;
 
 /**
  * If there aren't any filters, the default subscriptions are added.
  * However, if patterns.ini already did exist and/or any preference
  * is set to a non-default value, this indicates that this isn't the
  * first run, but something went wrong.
  *
@@ skipping 187 matching lines @@
     subscriptions = subscriptionsCallback(subscriptions);
 
   for (let subscription of subscriptions)
   {
     FilterStorage.addSubscription(subscription);
     if (subscription instanceof DownloadableSubscription &&
         !subscription.lastDownload)
       Synchronizer.execute(subscription);
   }
 
-  if (!Prefs.suppress_first_run_page)
+  if (!Prefs.suppress_first_run_page && firstRun)
   {
-    let page = null;
-    if (firstRun)
-    {
-      page = "firstRun.html";
-    }
-    // For now we're limiting the updates page to users of
-    // Chromium-based browsers to gage its impact
-    else if (info.platform == "chromium" &&
-             updatesVersion > Prefs.last_updates_page_displayed)
-    {
-      page = "updates.html";
-    }
-
-    if (page)
-    {
-      browser.tabs.create({url: browser.extension.getURL(page)});
-
-      // For new users and users that have already seen this updates page we
-      // want to avoid showing it again for subsequent updates.
-      Prefs.last_updates_page_displayed = updatesVersion;
-    }
+    browser.tabs.create({url: browser.extension.getURL("firstRun.html")});
   }
 
   initNotifications();
 }
 
 Promise.all([FilterNotifier.once("load"),
              Prefs.untilLoaded]).then(detectFirstRun)
                                 .then(getSubscriptions)
                                 .then(finishInitialization);
 
@@ skipping 10 matching lines @@
  * Sets a callback that is called with an array of subscriptions to be added
  * during initialization. The callback must return an array of subscriptions
  * that will effectively be added.
  *
  * @param {function} callback
  */
 exports.setSubscriptionsCallback = callback =>
 {
   subscriptionsCallback = callback;
 };