Issue 6599 - Detect data corruption of storage.local

lib/subscriptionInit.js

Index: lib/subscriptionInit.js
===================================================================
--- a/lib/subscriptionInit.js
+++ b/lib/subscriptionInit.js
@@ -241,7 +241,7 @@
   if (!Prefs.suppress_first_run_page)
   {
     let page = null;
-    if (firstRun)
+    if (firstRun || exports.dataCorrupted)

[kzar, 2018/04/24 11:18:01]

Well surely this would mean that the first run page constantly opens instead of
the updates page for these users with corrupted data?

Shouldn't we show a page which explains that their data is corrupted and that
they should try reinstalling the extension? Also I wonder if there's another way
to store a flag to somehow avoid constantly showing the page (or if that's a
good idea)?

[Sebastian Noack, 2018/04/24 11:26:26]

Yes, that is the idea, to add this message to the first run page, but hide it
unless dataCorrupted is set. Note that this how we already handle the
"reinitialized" flag.

[kzar, 2018/04/24 13:34:00]

Fair enough, I guess we need to also update the adblockplusui dependency to
include that with along with this change.

     {
       page = "firstRun.html";
     }
@@ -266,10 +266,12 @@
   initNotifications();
 }
 
-Promise.all([FilterNotifier.once("load"),
-             Prefs.untilLoaded]).then(detectFirstRun)
-                                .then(getSubscriptions)
-                                .then(finishInitialization);
+Promise.all([
+  FilterNotifier.once("load"),
+  Prefs.untilLoaded.catch(() => { exports.dataCorrupted = true; })
+]).then(detectFirstRun)
+  .then(getSubscriptions)
+  .then(finishInitialization);
 
 /**
  * Indicates whether the default filter subscriptions have been added
@@ -281,6 +283,13 @@
 exports.reinitialized = false;
 
 /**
+ * Indicates whether a data corruption was detcted.
+ *
+ * @type {boolean}
+ */
+exports.dataCorrupted = false;
+
+/**
  * Sets a callback that is called with an array of subscriptions to be added
  * during initialization. The callback must return an array of subscriptions
  * that will effectively be added.