Issue 6238 - Download/store notifications.json

adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/DownloadJobService.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 22 matching lines @@
 import android.os.PersistableBundle;
 import android.util.Log;
 
 import javax.net.ssl.HttpsURLConnection;
 
 /**
  * JobService that handles download jobs
  */
 public class DownloadJobService extends JobService implements EngineManager.OnEngineCreatedCallback
 {
-

[anton, 2018/05/03 07:23:20]

is empty line required here?

[jens, 2018/05/03 07:44:37]

Acknowledged.

-  static final String TAG = DownloadJobService.class.getSimpleName();

[anton, 2018/05/03 07:23:20]

shouldn't it be `private`?

[jens, 2018/05/03 07:44:37]

Acknowledged.

+  private static final String TAG = DownloadJobService.class.getSimpleName();
   private DownloadJobAsyncTask downloadJobAsyncTask = null;
-  private Engine engine;

[anton, 2018/05/03 07:23:20]

i think `engine` should be initialized as `null` to be consistent with
`downloadJobAsyncTask` (line above) or `downloadJobAsyncTask` not initialized to
`null`.

[jens, 2018/05/03 07:44:37]

Acknowledged.

+  private Engine engine = null;
 
   @Override
   public void onCreate()
   {
     super.onCreate();
     Log.i(TAG, "DownloadJobService created.");
     EngineManager.getInstance().retrieveEngine(this, this);
   }
 
   @Override
@@ skipping 119 matching lines @@
       return job;
     }
   }
 
   private static class DownloadJob
   {
     private final URL url;
     private final String id;
     private final HashMap<String, String> headers = new HashMap<>();
 
-    private int responseCode = 0;
+    private int responseCode;
     private final HashMap<String, String> responseHeaders = new HashMap<>();
-    private String responseText = null;
+    private String responseText;
 
     DownloadJob(final URL url, final String id, final Map<String, String> headers)
     {
       this.url = url;
       this.id = id;
       if (headers != null)
       {
         this.headers.putAll(headers);
       }
     }
   }
 }