Issue 6238 - Download/store notifications.json

adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/DownloadJobService.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 164 matching lines @@
       return job;
     }
   }
 
   private static class DownloadJob
   {
     private final URL url;
     private final String id;
     private final HashMap<String, String> headers = new HashMap<>();
 
-    private int responseCode = 0;

[diegocarloslima, 2018/05/10 13:41:58]

No need to initialize it with 0 here, this is done by default

[jens, 2018/05/15 09:17:02]

Acknowledged.

+    private int responseCode;
     private final HashMap<String, String> responseHeaders = new HashMap<>();
-    private String responseText = null;
+    private String responseText;
 
     DownloadJob(final URL url, final String id, final Map<String, String> headers)
     {
       this.url = url;
       this.id = id;
       if (headers != null)
       {
         this.headers.putAll(headers);
       }
     }
   }
 }