Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/DownloadJobService.java

Issue 29760569: Issue 6238 - Download/store notifications.json (Closed)
Left Patch Set: Created May 15, 2018, 9:17 a.m.
Right Patch Set: Created May 15, 2018, 9:57 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 } 177 }
178 178
179 private static class DownloadJob 179 private static class DownloadJob
180 { 180 {
181 private final URL url; 181 private final URL url;
182 private final String id; 182 private final String id;
183 private final HashMap<String, String> headers = new HashMap<>(); 183 private final HashMap<String, String> headers = new HashMap<>();
184 184
185 private int responseCode; 185 private int responseCode;
186 private final HashMap<String, String> responseHeaders = new HashMap<>(); 186 private final HashMap<String, String> responseHeaders = new HashMap<>();
187 private String responseText = null; 187 private String responseText;
anton 2018/05/15 09:55:56 what about removing init to `null` here too? (if y
jens 2018/05/15 09:57:45 Acknowledged. I removed it and added a new patch s
188 188
189 DownloadJob(final URL url, final String id, final Map<String, String> header s) 189 DownloadJob(final URL url, final String id, final Map<String, String> header s)
190 { 190 {
191 this.url = url; 191 this.url = url;
192 this.id = id; 192 this.id = id;
193 if (headers != null) 193 if (headers != null)
194 { 194 {
195 this.headers.putAll(headers); 195 this.headers.putAll(headers);
196 } 196 }
197 } 197 }
198 } 198 }
199 } 199 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld