Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: adblockplussbrowser/AndroidManifest.xml

Issue 29760569: Issue 6238 - Download/store notifications.json (Closed)
Patch Set: Created April 26, 2018, 12:45 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: adblockplussbrowser/AndroidManifest.xml
===================================================================
--- a/adblockplussbrowser/AndroidManifest.xml
+++ b/adblockplussbrowser/AndroidManifest.xml
@@ -31,11 +31,15 @@
<meta-data
android:name="com.samsung.android.sbrowser.contentBlocker.interfaceVersion"
android:value="API_1.0" />
<provider
android:name="org.adblockplus.sbrowser.contentblocker.ContentBlockerContentProvider"
android:authorities="${applicationId}.contentBlocker.contentProvider"
android:exported="true" />
+
+ <service
+ android:name="org.adblockplus.sbrowser.contentblocker.engine.DownloadJobService"
+ android:permission="android.permission.BIND_JOB_SERVICE" />
anton 2018/05/03 07:23:20 should not we add `android:exported="false"` here?
jens 2018/05/03 07:44:37 The default value of android:exported is false if
anton 2018/05/03 07:56:26 Acknowledged.
</application>
</manifest>

Powered by Google App Engine
This is Rietveld