Issue 6618 - Prefer CSS selectors for plain emulation filters

lib/content/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 209 matching lines @@
   yield null;
 }
 
 function PlainSelector(selector)
 {
   this._selector = selector;
   this.maybeDependsOnAttributes = /[#.]|\[.+\]/.test(selector);
 }
 
 PlainSelector.prototype = {
+  preferHideWithSelector: true,
+
   /**
    * Generator function returning a pair of selector
    * string and subtree.
    * @param {string} prefix the prefix for the selector.
    * @param {Node} subtree the subtree we work on.
    * @param {StringifiedStyle[]} styles the stringified style objects.
    */
   *getSelectors(prefix, subtree, styles)
   {
     yield [prefix + this._selector, subtree];
@@ skipping 161 matching lines @@
 {
   this.selectors = selectors;
   this.text = text;
 }
 
 Pattern.prototype = {
   isSelectorHidingOnlyPattern()
   {
     return getCachedPropertyValue(
       this, "_selectorHidingOnlyPattern",
-      () => this.selectors.some(selector => selector.preferHideWithSelector) &&
+      () => this.selectors.every(selector => selector.preferHideWithSelector) &&
             !this.selectors.some(selector => selector.requiresHiding)
     );
   },
 
   get dependsOnStyles()
   {
     return getCachedPropertyValue(
       this, "_dependsOnStyles",
       () => this.selectors.some(selector => selector.dependsOnStyles)
     );
@@ skipping 413 matching lines @@
           characterData: shouldObserveCharacterData(this.patterns),
           subtree: true
         }
       );
       this.document.addEventListener("load", this.onLoad.bind(this), true);
     }
   }
 };
 
 exports.ElemHideEmulation = ElemHideEmulation;