Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29760634: Noissue - Update Chromium and chrome-remote-interface versions (Closed)

Created:
April 24, 2018, 1:10 p.m. by Manish Jethani
Modified:
April 27, 2018, 2:03 p.m.
Reviewers:
hub
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Update Chromium and chrome-remote-interface versions

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromium_process.js View 1 chunk +1 line, -1 line 0 comments Download
M package.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Manish Jethani
April 24, 2018, 1:10 p.m. (2018-04-24 13:10:48 UTC) #1
Manish Jethani
Patch Set 1 We should update these to the latest versions so we know we're ...
April 24, 2018, 1:12 p.m. (2018-04-24 13:12:59 UTC) #2
hub
April 24, 2018, 1:21 p.m. (2018-04-24 13:21:23 UTC) #3
I think it is still good to test on the older version we support.

Also moving forward, we have https://issues.adblockplus.org/ticket/6391 that is
about running the tests using WebDriver so that we can run them on Firefox too.

Powered by Google App Engine
This is Rietveld