Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/extensions/bin/createNightlies.py

Issue 29760638: Issue 6611 - don't keep unsigned .xpi files (Closed)
Patch Set: Created April 24, 2018, 1:15 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« .sitescripts.example ('K') | « .sitescripts.example ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/extensions/bin/createNightlies.py
diff --git a/sitescripts/extensions/bin/createNightlies.py b/sitescripts/extensions/bin/createNightlies.py
index ed2cabfbe1977fb84e53b3be74c116d2f88d9912..6d8f4d23aae9aec8d8ded3ec02ccb42c4ebe8e2c 100644
--- a/sitescripts/extensions/bin/createNightlies.py
+++ b/sitescripts/extensions/bin/createNightlies.py
@@ -317,7 +317,12 @@ class NightlyBuild(object):
"""
run the build command in the tempdir
"""
- baseDir = os.path.join(self.config.nightliesDirectory, self.basename)
+ if self.config.type not in self.downloadable_repos:
+ baseDir = os.path.join(self.config.nightliesDirectory,
+ self.basename)
+ else:
+ baseDir = self.tempdir
+
if not os.path.exists(baseDir):
os.makedirs(baseDir)
outputFile = '%s-%s%s' % (self.basename, self.version, self.config.packageSuffix)
@@ -515,6 +520,11 @@ class NightlyBuild(object):
try:
urllib2.urlopen(request).close()
except urllib2.HTTPError as e:
+ shutil.copyfile(
+ self.path,
+ os.path.join(get_config().get('extensions', 'root'),
+ 'failed.' + self.config.packageSuffix),
+ )
try:
logging.error(e.read())
finally:
« .sitescripts.example ('K') | « .sitescripts.example ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld