Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(645)

Issue 29760699: Issue 6619 - Qualify CSS selectors in document style sheet correctly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 4 weeks ago by Manish Jethani
Modified:
2 months, 3 weeks ago
Reviewers:
hub
CC:
sergei, kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rebase #

Patch Set 3 : Add JSDoc for qualifySelector #

Patch Set 4 : Reinclude test/common.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -2 lines) Patch
M lib/common.js View 1 2 1 chunk +102 lines, -0 lines 0 comments Download
M lib/content/elemHideEmulation.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
A test/common.js View 2 3 1 chunk +188 lines, -0 lines 0 comments Download

Messages

Total messages: 12
Manish Jethani
4 months, 4 weeks ago (2018-04-24 19:14:31 UTC) #1
Manish Jethani
Patch Set 1 See test/common.js first.
4 months, 4 weeks ago (2018-04-24 19:15:42 UTC) #2
Manish Jethani
Oh shoot, this won't work for filters like the following from EasyList: webfail.com###aside > [-abp-properties='cursor: ...
4 months, 3 weeks ago (2018-04-24 19:56:34 UTC) #3
hub
Also to would be nice to have a concrete test in elemHideEmulation with DOM that ...
4 months, 3 weeks ago (2018-04-26 03:31:16 UTC) #4
Manish Jethani
On 2018/04/24 19:56:34, Manish Jethani wrote: > Oh shoot, this won't work for filters like ...
4 months, 1 week ago (2018-05-10 02:20:10 UTC) #5
Manish Jethani
On 2018/04/26 03:31:16, hub wrote: > Also to would be nice to have a concrete ...
4 months, 1 week ago (2018-05-10 02:20:44 UTC) #6
hub
A few comments. Otherwise, this is looking good. https://codereview.adblockplus.org/29760699/diff/29760700/lib/common.js File lib/common.js (right): https://codereview.adblockplus.org/29760699/diff/29760700/lib/common.js#newcode175 lib/common.js:175: function ...
4 months, 1 week ago (2018-05-14 19:35:13 UTC) #7
Manish Jethani
Patch Set 2: Rebase Patch Set 3: Add JSDoc for qualifySelector https://codereview.adblockplus.org/29760699/diff/29760700/lib/common.js File lib/common.js (right): ...
4 months, 1 week ago (2018-05-15 12:03:58 UTC) #8
hub
test/common.js seems to be gone in this revision of the patch.
4 months, 1 week ago (2018-05-15 17:05:50 UTC) #9
Manish Jethani
Patch Set 4: Reinclude test/common.js Sorry about that.
4 months, 1 week ago (2018-05-15 17:19:52 UTC) #10
hub
LGTM Dave, any comments ?
4 months, 1 week ago (2018-05-15 17:39:33 UTC) #11
Manish Jethani
3 months, 3 weeks ago (2018-05-29 00:24:25 UTC) #12
On 2018/05/15 17:39:33, hub wrote:
> LGTM

Thanks!

> Dave, any comments ?

Moved Dave to reviewers.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5