Issue 6592 - Implement $rewrite filter option

test/_common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 13 matching lines @@
 const Cr = exports.Cr = {
   NS_OK: 0,
   NS_BINDING_ABORTED: 0x804B0002,
   NS_ERROR_FAILURE: 0x80004005
 };
 
 const MILLIS_IN_SECOND = exports.MILLIS_IN_SECOND = 1000;
 const MILLIS_IN_MINUTE = exports.MILLIS_IN_MINUTE = 60 * MILLIS_IN_SECOND;
 const MILLIS_IN_HOUR = exports.MILLIS_IN_HOUR = 60 * MILLIS_IN_MINUTE;
 
-function URL(urlString)

[kzar, 2018/05/15 14:08:58]

What's with this change?

[hub, 2018/05/15 16:16:31]

This one is required: it was a polyfill for the URL API that NodeJS didn't have.
And right now it breaks if left in since it is incomplete, and no longer needed.

[hub, 2018/05/15 16:17:53]

And I must add: this is only used in the tests.

[kzar, 2018/05/16 09:22:40]

I think this was for Node.js 7 compatability which (according to the README in
adblockpluschrome and adblockpluscore) we still support so far. 

I'm not against making Node.js 8 the minimum version, so long as you update the
READMEs too, what do you think Sebastian? 

[Sebastian Noack, 2018/05/16 10:53:29]

I'm on Node.js 8.5, and there is no global URL object either.

[hub, 2018/05/16 12:08:11]

According to the documentation, it was added in Node 7

https://nodejs.org/dist/latest-v8.x/docs/api/url.html#url_the_whatwg_url_api

[Sebastian Noack, 2018/05/16 12:13:22]

Yes, the code here could be changed to:

  const {URL} = require("url");

And it seems that this should even work with Node.js 7. What I meant, is merely
that there is no global URL object in Node.js

[hub, 2018/05/16 13:11:49]

It is global in NodeJS 10.
See
https://nodejs.org/dist/latest-v10.x/docs/api/url.html#url_the_whatwg_url_api

-{
-  return require("url").parse(urlString);
-}
-
 let Services = {
   obs: {
     addObserver() {}
   }
 };
 let XPCOMUtils = {
   generateQI() {}
 };
 let FileUtils = {};
 let resources = {Services, XPCOMUtils, FileUtils};
@@ skipping 360 matching lines @@
       }
     })
   };
 };
 
 exports.unexpectedError = function(error)
 {
   console.error(error);
   this.ok(false, "Unexpected error: " + error);
 };