dependencies - Issue 29760707: Issue 6622 - Implement $rewrite filter option

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: dependencies

Issue 29760707: Issue 6622 - Implement $rewrite filter option (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: Rename rewrittenTo to rewrittenUrl. Adjust some comments. Created May 15, 2018, 4:31 p.m.

Right Patch Set: Updated proper revision for adblockpluscore. No dependency change for ui Created May 18, 2018, 3:27 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:47429f8d9b6a git:bd1a0d2	3 buildtools = buildtools hg:47429f8d9b6a git:bd1a0d2

4 adblockpluscore = adblockpluscore hg:89490da18380 git:8508af0	4 adblockpluscore = adblockpluscore hg:e59042524857 git:8904bce
Sebastian Noack 2018/05/18 15:13:30 This revision seems to be wrong: https://hg.adbloc This revision seems to be wrong: https://hg.adblockplus.org/adblockpluscore/rev/e59042524857 hub 2018/05/18 15:28:49 I had the right one locally (both mercurial and gi Show quoted text On 2018/05/18 15:13:30, Sebastian Noack wrote: > This revision seems to be wrong: > https://hg.adblockplus.org/adblockpluscore/rev/e59042524857 I had the right one locally (both mercurial and git). Will update the patch.
5 adblockplusui = adblockplusui hg:ff614a2838a9 git:dcb681f	5 adblockplusui = adblockplusui hg:8c49749e63e7 git:dcb681f
Sebastian Noack 2018/05/18 15:13:30 I knew that I previously said otherwise, but given I knew that I previously said otherwise, but given the new workflow in adblockplusui, I don't think anymore that we should wait for the adblockplusui dependency being ready to be updated before landing this. For reference, the related adblockplusui change already landed, not in Mercurial but in a feature branch on GitLab, which is merged back to Mercurial once all UI changes (including translations are ready), i.e. right before code freeze. hub 2018/05/18 15:28:49 I'll revert this dependency. We'll update it as so Show quoted text On 2018/05/18 15:13:30, Sebastian Noack wrote: > I knew that I previously said otherwise, but given the new workflow in > adblockplusui, I don't think anymore that we should wait for the adblockplusui > dependency being ready to be updated before landing this. > > For reference, the related adblockplusui change already landed, not in Mercurial > but in a feature branch on GitLab, which is merged back to Mercurial once all UI > changes (including translations are ready), i.e. right before code freeze. I'll revert this dependency. We'll update it as soon as we can.
LEFT	RIGHT