Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/requestBlocker.js

Issue 29760707: Issue 6622 - Implement $rewrite filter option (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Remove uneeded check Created May 3, 2018, 6:42 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/devtools.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/requestBlocker.js
===================================================================
--- a/lib/requestBlocker.js
+++ b/lib/requestBlocker.js
@@ -65,20 +65,21 @@
for (let type in browser.webRequest.ResourceType)
yield resourceTypes.get(browser.webRequest.ResourceType[type]) || "OTHER";
// WEBRTC gets addressed through a workaround, even if the webRequest API is
// lacking support to block this kind of a request.
yield "WEBRTC";
- // POPUP, CSP and ELEMHIDE filters aren't mapped to resource types.
+ // These filter types aren't mapped to resource types.
yield "POPUP";
yield "ELEMHIDE";
yield "CSP";
+ yield "REWRITE";
}());
function getDocumentInfo(page, frame, originUrl)
{
return [
extractHostFromFrame(frame, originUrl),
getKey(page, frame, originUrl),
!!checkWhitelisted(page, frame, originUrl,
@@ -189,24 +190,41 @@
return;
let type = resourceTypes.get(details.type) || "OTHER";
let [docDomain, sitekey, specificOnly] = getDocumentInfo(page, frame,
originUrl);
let [filter, urlString, thirdParty] = matchRequest(url, type, docDomain,
sitekey, specificOnly);
+ let result;
+
+ if (filter instanceof BlockingFilter)
+ {
+ if (filter.rewrite)
+ {
+ let rewritten = filter.rewriteUrl(urlString);
+ if (rewritten == urlString)
Manish Jethani 2018/05/04 15:37:47 Do we still need this check? If the filter matched
hub 2018/05/04 18:27:58 definitely. a redirectUrl will cause onBeforeReque
+ // we couldn't do the rewrite, so just let it through.
+ return;
+
+ type = "REWRITE";
Manish Jethani 2018/05/04 15:37:47 Also I'm wondering if it makes sense to set the ty
Sebastian Noack 2018/05/04 15:46:49 I already thought the same, and tend to agree to n
hub 2018/05/04 18:27:58 I have a solution to indicate the rewrite in the d
+ result = {redirectUrl: rewritten};
+ }
+ else
+ result = {cancel: true};
+ }
+
getRelatedTabIds(details).then(tabIds =>
{
logRequest(tabIds, urlString, type, docDomain,
thirdParty, sitekey, specificOnly, filter);
});
- if (filter instanceof BlockingFilter)
- return {cancel: true};
+ return result;
}, {urls: ["<all_urls>"]}, ["blocking"]);
port.on("filters.collapse", (message, sender) =>
{
let {page, frame} = sender;
if (checkWhitelisted(page, frame))
return false;
« no previous file with comments | « lib/devtools.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld