Unified Diff: lib/devtools.js
Issue 29760707:
Issue 6622 - Implement $rewrite filter option (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Log all request, even failed rewrites. + comment
Created May 4, 2018, 8:46 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« dependencies ('k')
|
lib/requestBlocker.js » ('j')
|
lib/requestBlocker.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/devtools.js |
| =================================================================== |
| --- a/lib/devtools.js |
| +++ b/lib/devtools.js |
| @@ -125,27 +125,30 @@ |
| * @param {string} type The request type |
| * @param {string} docDomain The IDN-decoded hostname of the document |
| * @param {boolean} thirdParty Whether the origin of the request and |
| * document differs |
| * @param {?string} sitekey The active sitekey if there is any |
| * @param {?boolean} specificOnly Whether generic filters should be ignored |
| * @param {?BlockingFilter} filter The matched filter or null if there is no |
| * match |
| + * @param {?string} rewrittenTo The query URL was rewritten to this new URL |
| */ |
| exports.logRequest = function(tabIds, url, type, docDomain, |
| thirdParty, sitekey, |
| - specificOnly, filter) |
| + specificOnly, filter, rewrittenTo) |
| { |
| for (let tabId of tabIds) |
| { |
| let panel = getActivePanel(tabId); |
| if (panel) |
| { |
| - let request = {url, type, docDomain, thirdParty, sitekey, specificOnly}; |
| + let request = { |
| + url, type, docDomain, thirdParty, sitekey, specificOnly, rewrittenTo |
| + }; |
| addRecord(panel, request, filter); |
| } |
| } |
| }; |
| /** |
| * Logs active element hiding filters to the devtools panel. |
| * |
« no previous file with comments
|
« dependencies ('k')
|
lib/requestBlocker.js » ('j')
|
lib/requestBlocker.js » ('J')
