#8852 - ldap sync output filter

edit.sh

 #!/bin/sh
 
-# Filtering out uninformative output lines from the ldap-sync cron job script

[f.lopez, 2018/05/29 21:18:48]

I don't think this script is only for cron jobs, even tho this could be the use
case right now, also don't use gerund or infinitive for the description,
"Filtering" -> "Filter"

+# Filter out uninformative output lines from the ldap-sync cron job script
 
-last_updated=""
+last_action=""
 
 while read line; do
+  case "$line" in
+    *-\>*)
+      if [ ! -z "$last_action" ]
+      then
+        echo "$last_action"
+      fi
 

[f.lopez, 2018/05/29 21:18:49]

be consistent here, either always use a blank line between each block, or not,
but if you are using blank lines, then it should be one between `esac` and
`done`, in this case tho, for readability, I wouldn't use blank lines

-  case $line in
-

[f.lopez, 2018/05/29 21:18:48]

not blank lines here either

-    *Updating*|*Creating*)
-      last_updated="$line"
+      echo "$line"
+      last_action=""
       ;;
-

[f.lopez, 2018/05/29 21:18:48]

not blank lines between each option either

-    *-\>*)
-      echo $last_updated

[f.lopez, 2018/05/29 21:18:48]

this is a regression, I mentioned in the first code review that, as a general
rule, and unless you know what you are doing, you should always quote variables
to avoid globbing and word splitting.

Please go through the following link
http://www.tldp.org/LDP/abs/html/quoting.html

-      echo $line
+    --\ Found\ *\ users* | \
+    \#* | \
+    *Synchronizing\ *\ groups* | \
+    \*\*\ Synchronizing\ *\ users* | \
+    --\ Updating\ user\ \'*\'?\(*\)* | \
+    --\ Updating\ group\ \'*\'* | \
+    --\ Creating\ user\ \'*\'?\(*\)* | \
+    --\ Creating\ group\ \'*\'*)
+      last_action="$line"
       ;;
-
-    *Found*|*\#*|*Synchronizing*)

[f.lopez, 2018/05/29 21:18:48]

We always avoid modifying unrelated changes, in this case, if you need to
modify/add/delete a term that don't need special treatment, you will modify the
whole line, which would be an unrelated changes,

something like:

```
*Found* | \
*\#* | \
*Synchronizing*)
```

-      continue
-      ;;
-
     *)
-      echo $line
+      echo "$line"
       ;;
   esac
 done