#8852 - ldap sync output filter

edit.sh

 #!/bin/sh
 
 # Filter out uninformative output lines from the ldap-sync cron job script
 
 last_action=""
-last_updated=""
 
 while read line; do
   case "$line" in
-    *Updating*|*Creating*)

[mathias, 2018/06/11 14:10:56]

Please make the patterns a bit more specific, in order to minimize the risk of
filtering-out false-positives. Thank you! 

-      last_updated="$line"
+    *-\>*)
+      if [ ! -z "$last_action" ]
+      then
+        echo "$last_action"
+      fi
+
+      echo "$line"
+      last_action=""
       ;;
-    *-\>*)
-      case "$last_action" in

[mathias, 2018/06/11 14:10:56]

It is not a good idea to base the decision whether to print `$last_updated` on a
replica of the former condition (`case "$last_action" in ...`). This is
repeating the same logic and therefore creating a 2nd point of possible failure
for the exact same condition.

In this case, for example, you could just set `last_updated=""` (an empty
string) after echoing, and `test -z "$last_updated"` to determine whether to
print the last line or not.

In general, in order to avoid conditional statements being evaluated a 2nd time
(which could have side-effects in each run), you can write the result to a
variable and just check on that one.

-        *-\>*)
-          echo "$line"
-          ;;
-        *)
-          echo "$last_updated"
-          echo "$line"
-          ;;
-      esac
-      ;;
-    *Found* | \
-    *\#* | \
-    *Synchronizing*)
-      continue
+    --\ Found\ *\ users* | \
+    \#* | \
+    *Synchronizing\ *\ groups* | \
+    \*\*\ Synchronizing\ *\ users* | \
+    --\ Updating\ user\ \'*\'?\(*\)* | \
+    --\ Updating\ group\ \'*\'* | \
+    --\ Creating\ user\ \'*\'?\(*\)* | \
+    --\ Creating\ group\ \'*\'*)
+      last_action="$line"
       ;;
     *)
       echo "$line"
       ;;
   esac
-
-  last_action="$line"
 done