edit.sh - Issue 29761555: #8852 - ldap sync output filter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: edit.sh

Issue 29761555: #8852 - ldap sync output filter (Closed)

Left Patch Set: #8852 - ldap sync output filter Created June 12, 2018, 2:50 p.m.

Right Patch Set: #8852 - ldap sync output filter Created June 20, 2018, 12:32 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #!/bin/sh	1 #!/bin/sh

2	2

3 # Filter out uninformative output lines from the ldap-sync cron job script	3 # Filter out uninformative output lines from the ldap-sync cron job script

4	4

5 last_action=""	5 last_action=""

6	6

7 while read line; do	7 while read line; do

8 case "$line" in	8 case "$line" in

9 -\>)	9 -\>)

10 case "$last_action" in	10 if [ ! -z "$last_action" ]
mathias 2018/06/19 13:12:39 As discussed, please replace the inner `case` stat As discussed, please replace the inner `case` statement here with something along the lines below: if [ ! -z "$last_action" ]; then echo "$last_action" last_action= fi echo "$line"
11 -\>)	11 then

12 echo "$line"	12 echo "$last_action"

13 ;;	13 fi

14 *)	14

15 echo "$last_action"	15 echo "$line"

16 echo "$line"	16 last_action=""

17 last_action="$line"

18 ;;

19 esac

20 ;;	17 ;;

21 Foundusers* \| \	18 --\ Found\ \ users \| \
mathias 2018/06/19 13:12:40 How about `"* Found * users "`? How about `" Found * users *"`?
22 \# \| \	19 \#* \| \

23 Synchronizinggroups* \| \	20 Synchronizing\ \ groups* \| \

24 Synchronizingusers* \| \	21 \\\ Synchronizing\ \ users \| \

25 Updating?user?\'\'?$$ \| \	22 --\ Updating\ user\ \'\'?$$* \| \

26 Updating?group?\'\'* \| \	23 --\ Updating\ group\ \'\' \| \

27 Creating?user?\'\'?$$ \| \	24 --\ Creating\ user\ \'\'?$$* \| \

28 Creating?group?\'\'*)	25 --\ Creating\ group\ \'\')

29 last_action="$line"	26 last_action="$line"

30 continue
mathias 2018/06/19 13:12:39 Not: The `continue` statement is not exactly neces Not: The `continue` statement is not exactly necessary here.
31 ;;	27 ;;

32 *)	28 *)

33 echo "$line"	29 echo "$line"

34 ;;	30 ;;

35 esac	31 esac

36 done	32 done

LEFT	RIGHT